[Zope-dev] Re: [Zope2.8a2] ...to be released by tomorrow....
Tres Seaver wrote: http://cvs.zope.org/Zope/lib/python/AccessControl/Attic/ZopeGuards.py.diff?r1=1.16.2.3&r2=1.16.2.4 [...] Hmm, that change hadn't landed on the gmane.org version of the checkins. I have it merged in my sandbox now, along with two apparently related changes (to the 'actual_python' and 'testZopeGuards' modules in lib/python/AccessControl/tests). That seems to be the complete change, see http://cvs.zope.org/query?branch=Zope-2_7-branch&who=evan&sortby=date&date=all#results Evan, do you recall whether you made related changes outside of the AccessControl package (e.g, in PythonScripts, ZPT, etc.)? HTH, Yuppie ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Zope2.8a2] ...to be released by tomorrow....
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 yuppie wrote: > Tres Seaver wrote: > >>> I still have a notion that some improvements made on the 2.7 branch are >>> not merged into the SVN trunk, e.g. >>> http://cvs.zope.org/Zope/lib/python/AccessControl/Attic/ZopeGuards.py.diff?r1=1.16.2.3&r2=1.16.2.4 >>> >> >> >> >> There is some debate here whether those changes (which Jim made only >> relunctantly back in January 2004) should be promulgated to 2.8. >> We will fold them in after the alpha, if so. > > > The link above points to an other unmerged change. I don't understand > the complete change, but at least removing Python 2.1 compatibility code > should also be done on the trunk. Hmm, that change hadn't landed on the gmane.org version of the checkins. I have it merged in my sandbox now, along with two apparently related changes (to the 'actual_python' and 'testZopeGuards' modules in lib/python/AccessControl/tests). Evan, do you recall whether you made related changes outside of the AccessControl package (e.g, in PythonScripts, ZPT, etc.)? Tres. - -- === Tres Seaver[EMAIL PROTECTED] Zope Corporation "Zope Dealers" http://www.zope.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.5 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCUYMqGqWXf00rNCgRAjEsAJ4q8c9PHFq5vYrS2XKo5yEJ1/CfjQCfVGR7 8FN4IF6GuQ0Q83y1qJj317k= =a6ji -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Zope2.8a2] ...to be released by tomorrow....
Tres Seaver wrote: I still have a notion that some improvements made on the 2.7 branch are not merged into the SVN trunk, e.g. http://cvs.zope.org/Zope/lib/python/AccessControl/Attic/ZopeGuards.py.diff?r1=1.16.2.3&r2=1.16.2.4 There is some debate here whether those changes (which Jim made only relunctantly back in January 2004) should be promulgated to 2.8. We will fold them in after the alpha, if so. The link above points to an other unmerged change. I don't understand the complete change, but at least removing Python 2.1 compatibility code should also be done on the trunk. Cheers, Yuppie ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Zope2.8a2] ...to be released by tomorrow....
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 yuppie wrote: > Hi Tres! > > > Tres Seaver wrote: > >> Please try the patch I just checked in: >> >> http://svn.zope.org/Zope/?rev=29821&sortby=date&view=rev > > > Thanks! This resolves issue #1460. Merged it into the trunk to get it > into the alpha 2 release, hope that's ok. > >> There may be additional issues (e.g., Stuart Bishop's "checked >> __getitem__" use case), but this makes the test script and the CMF work >> for me. > > > I still have a notion that some improvements made on the 2.7 branch are > not merged into the SVN trunk, e.g. > http://cvs.zope.org/Zope/lib/python/AccessControl/Attic/ZopeGuards.py.diff?r1=1.16.2.3&r2=1.16.2.4 There is some debate here whether those changes (which Jim made only relunctantly back in January 2004) should be promulgated to 2.8. We will fold them in after the alpha, if so. Tres. - -- === Tres Seaver[EMAIL PROTECTED] Zope Corporation "Zope Dealers" http://www.zope.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCTxjaGqWXf00rNCgRAjKKAKCGXAyHBngiB+Q2Fw4HGK4/sv1ZcQCdFq9J WGDBkybeCWQ9/GgGW9sj4ck= =HVcX -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Zope2.8a2] ...to be released by tomorrow....
Hi Tres! Tres Seaver wrote: Please try the patch I just checked in: http://svn.zope.org/Zope/?rev=29821&sortby=date&view=rev Thanks! This resolves issue #1460. Merged it into the trunk to get it into the alpha 2 release, hope that's ok. There may be additional issues (e.g., Stuart Bishop's "checked __getitem__" use case), but this makes the test script and the CMF work for me. I still have a notion that some improvements made on the 2.7 branch are not merged into the SVN trunk, e.g. http://cvs.zope.org/Zope/lib/python/AccessControl/Attic/ZopeGuards.py.diff?r1=1.16.2.3&r2=1.16.2.4 Cheers, Yuppie ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Zope2.8a2] ...to be released by tomorrow....
--On Freitag, 1. April 2005 18:44 Uhr -0500 Tim Peters <[EMAIL PROTECTED]> wrote: [Tim Peters] ... All the substantive changes I needed to make were completed last night, and the overnight test runs were successful. I still need to write up ZODB NEWS, fiddle the version numbers, make a 3.4a1 release tag, and edit the svn:externals in Zope trunk to point at that tag. That's all very low risk, so just assume it's been done if I don't say anything else later. Still, explicit is better than implicit: that's all been done, are there are no remaining ZODB issues holding up release of Zope 2.8a2. Excellent! Thanks, Andreas pgpIUdc1BkvOR.pgp Description: PGP signature ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Zope2.8a2] ...to be released by tomorrow....
[Tim Peters] > ... > All the substantive changes I needed to make were completed last > night, and the overnight test runs were successful. I still need to > write up ZODB NEWS, fiddle the version numbers, make a 3.4a1 release > tag, and edit the svn:externals in Zope trunk to point at that tag. > That's all very low risk, so just assume it's been done if I don't say > anything else later. Still, explicit is better than implicit: that's all been done, are there are no remaining ZODB issues holding up release of Zope 2.8a2. ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Zope2.8a2] ...to be released by tomorrow....
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 yuppie wrote: > Tres Seaver wrote: > >>> I'd really like to see http://www.zope.org/Collectors/Zope/1460 resolved >>> before the release: >>> >>> 1.) AFAICS this bug is easy to fix. >>> >>> 2.) It makes at least CMFDefault sites unusable, deterring CMF users >>> from testing Zope 2.8. >>> >>> I could merge the fix from the 2.7 branch myself, but I hate to check in >>> code I don't understand completely. Maybe Tres or Jim can have a look at >>> this? Or at least review the checkin if I do it myself? >> >> >> >> Jim and I fixed this last week: >> >> http://svn.zope.org/Zope/?rev=29712&sortby=date&view=rev >> >> I will resolve the issue. > > > Can't confirm that. I'm afraid you fixed something different. At least > the changes in ZopeGuards.py didn't make it into the trunk and I see > still the same errors. > > Please test it yourself with the small script in Entry #1 of > http://www.zope.org/Collectors/Zope/1460 or with a CMF 1.5/HEAD > CMFDefault site. Please try the patch I just checked in: http://svn.zope.org/Zope/?rev=29821&sortby=date&view=rev There may be additional issues (e.g., Stuart Bishop's "checked __getitem__" use case), but this makes the test script and the CMF work for me. Tres. - -- === Tres Seaver[EMAIL PROTECTED] Zope Corporation "Zope Dealers" http://www.zope.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCTdtEGqWXf00rNCgRAreSAJ4joVm4DHkIk5uBj6nEGqtH1jza4wCgjYf4 bfHieizFRq1pejtLWQaiN3I= =d3ni -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Zope2.8a2] ...to be released by tomorrow....
Hi Tres! Tres Seaver wrote: I'd really like to see http://www.zope.org/Collectors/Zope/1460 resolved before the release: 1.) AFAICS this bug is easy to fix. 2.) It makes at least CMFDefault sites unusable, deterring CMF users from testing Zope 2.8. I could merge the fix from the 2.7 branch myself, but I hate to check in code I don't understand completely. Maybe Tres or Jim can have a look at this? Or at least review the checkin if I do it myself? Jim and I fixed this last week: http://svn.zope.org/Zope/?rev=29712&sortby=date&view=rev I will resolve the issue. Can't confirm that. I'm afraid you fixed something different. At least the changes in ZopeGuards.py didn't make it into the trunk and I see still the same errors. Please test it yourself with the small script in Entry #1 of http://www.zope.org/Collectors/Zope/1460 or with a CMF 1.5/HEAD CMFDefault site. Cheers, Yuppie ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Zope2.8a2] ...to be released by tomorrow....
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 yuppie wrote: > Andreas Jung wrote: > >> I am planning to make the release tomorrow (Saturday afternoon (German >> time :-)). So please make >> your final fixes very soon or cry out loud STOP if there are any show >> stoppers. > > I'd really like to see http://www.zope.org/Collectors/Zope/1460 resolved > before the release: > > 1.) AFAICS this bug is easy to fix. > > 2.) It makes at least CMFDefault sites unusable, deterring CMF users > from testing Zope 2.8. > > I could merge the fix from the 2.7 branch myself, but I hate to check in > code I don't understand completely. Maybe Tres or Jim can have a look at > this? Or at least review the checkin if I do it myself? Jim and I fixed this last week: http://svn.zope.org/Zope/?rev=29712&sortby=date&view=rev I will resolve the issue. Tres - -- === Tres Seaver[EMAIL PROTECTED] Zope Corporation "Zope Dealers" http://www.zope.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCTWYcGqWXf00rNCgRAmJ7AJ9Z9pwnCROMi52HPj/Zu/PCrP6Z7gCfYpOy js/ESXDFYzn4mdoiLKiXGz4= =q4fr -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Zope2.8a2] ...to be released by tomorrow....
--On Freitag, 1. April 2005 11:43 Uhr +0200 yuppie <[EMAIL PROTECTED]> wrote: I could merge the fix from the 2.7 branch myself, but I hate to check in code I don't understand completely. Maybe Tres or Jim can have a look at this? Or at least review the checkin if I do it myself? Same here :-) If the patch is ok for people understanding the patch: go ahead and merge it. Andreas pgpgHmjXMoP5p.pgp Description: PGP signature ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: [Zope2.8a2] ...to be released by tomorrow....
Hi! Andreas Jung wrote: I am planning to make the release tomorrow (Saturday afternoon (German time :-)). So please make your final fixes very soon or cry out loud STOP if there are any show stoppers. I'd really like to see http://www.zope.org/Collectors/Zope/1460 resolved before the release: 1.) AFAICS this bug is easy to fix. 2.) It makes at least CMFDefault sites unusable, deterring CMF users from testing Zope 2.8. I could merge the fix from the 2.7 branch myself, but I hate to check in code I don't understand completely. Maybe Tres or Jim can have a look at this? Or at least review the checkin if I do it myself? Cheers, Yuppie ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )