Re: [Zope3-dev] The bug fixing problem
Hi, Marius Gedminas wrote: I do not think that the requirements to 4. Write unit tests 5. Merge bugfixes from trunk to the release branch 6. Wait for the incredibly slow updates on the collector discourage me all that much. Right. They don't discourage me either, but there is a special case in 4) which I hit several times lately, where the unit tests need very special effort. I think that if more bug reports had a solution outlined in English, I'd be more likely to go fix them every now and them. Indeed! Christian -- gocept gmbh & co. kg - forsterstraße 29 - 06112 halle/saale - germany www.gocept.com - [EMAIL PROTECTED] - phone +49 345 122 9889 7 - fax +49 345 122 9889 1 - zope and plone consulting and development ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
[Zope3-dev] Usage of the order attribute
repost to zope3-dev since I think it could be a bug... Hello, how is the order attribute of the menuItem directive being used? Do elements with a lower order come first? What is the order of elements that have not defined one? Is is higher than of all others. I wonder because I have menuItem defined with order 0 (or 1) and there is still one item above it which has not even order defined. Thanks, Florian ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] The bug fixing problem
On 7/5/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: There are bugs that do not need a test once they are fixed. All kinds of "NameError" and "AttributeError" fall into this category. The point of a test in most such cases is that there is a code path that isn't covered by tests, or it would have been caught earlier. A test that exercises the modified bit of code helps assure that future changes to the code don't introduce similar problems by providing at least one pass through the block containing the problem. How pressing the need for the test really is, is a matter for discussion, because the cost of writing the first test for an existing piece of code can be much higher than the cost of the fix. -Fred -- Fred L. Drake, Jr. "Every sin is the result of a collaboration." --Lucius Annaeus Seneca ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] The bug fixing problem
Christian Theune wrote at 2006-7-5 11:46 +0200: > ... >Another thing are the rules about unit tests. Some bugs touch areas that >are poorly tested. When I fix a bug over there, do I have to work harder >to introduce the fix because I have to start introducing tests? >We should find and announce a reasonable answer for the procedure in >this case. Although I have (so far) never fixed a bug in Zope 3 (but posted several patches for Zope 2), I can confirm this: There are bugs that do not need a test once they are fixed. All kinds of "NameError" and "AttributeError" fall into this category. Requiring to write a unit test for these or similarly trivial bugs is silly -- especially if there is not yet a testing file for the module (such that a trivial test would suffice). -- Dieter ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] The bug fixing problem
On Wed, Jul 05, 2006 at 11:46:52AM +0200, Christian Theune wrote: > I'm sitting at EuroPython right now, and a small discussion came up, > trying to find out why nobody seems motivated to fix bugs came up. ... > I feel like fixing a bug every now and then when I have like 30 minutes > spare time and want to do something useful. This happens to me about once a month. I get the "wanna fix a bug in 30 minutes" feeling, head over to the Zope 3 collection, and start browsing. Almost always I find no bug that I'd want to fix at the time. There are several reasons: 1. Some of the bug reports I do not understand. 2. Some of the bugs need changes in code that I'm not familiar with. 3. For some of the bugs it is unclear what ought to be done. (2) and (3) are pretty close, but (3) refers to behaviour visible from the outside, while (2) refers to implementation details. I do not think that the requirements to 4. Write unit tests 5. Merge bugfixes from trunk to the release branch 6. Wait for the incredibly slow updates on the collector discourage me all that much. I think that if more bug reports had a solution outlined in English, I'd be more likely to go fix them every now and them. Marius Gedminas -- We'll show a small example here with one user calling another. (Under international treaties describing technical papers these users must be called "Alice" and "Bob".) -- Anthony Baxter signature.asc Description: Digital signature ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
[Zope3-dev] The bug fixing problem
Hi, I'm sitting at EuroPython right now, and a small discussion came up, trying to find out why nobody seems motivated to fix bugs came up. Martijn Fassen noted that the tools we use should be better (I agree on that, especially making it easy to find which bugs need to be urgently fixed for the next release). Obviously that isn't a pure problem on it's own. As I was credited all the time for fixing many bugs for the next release, I'd like to jump in and explain what I think makes me not fix more bugs: I feel like fixing a bug every now and then when I have like 30 minutes spare time and want to do something useful. In my general experience of customer projects 30 minutes usually are enough to squash 1 or 2 (reasonably sized) bugs. I think we should encourage this pattern. I have a couple of feelings how we could do that, but can't sort those out completely right now. One thing that I'd very much like to see is that people who have an idea or a hint for fixing a bug attach that Another thing are the rules about unit tests. Some bugs touch areas that are poorly tested. When I fix a bug over there, do I have to work harder to introduce the fix because I have to start introducing tests? We should find and announce a reasonable answer for the procedure in this case. Christian -- gocept gmbh & co. kg - forsterstraße 29 - 06112 halle/saale - germany www.gocept.com - [EMAIL PROTECTED] - phone +49 345 122 9889 7 - fax +49 345 122 9889 1 - zope and plone consulting and development ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
