Re: [Zope3-dev] Broken homefolder tests
Am Dienstag, 7. Februar 2006 23:48 schrieb Roger Ineichen: Hi Stephan [...] No, this is usually painful tracking down. You could check for test setup code that assigns AttributeAnnotatable to File. Also note that there is no good way for tearing down classImplements() statements. So this issue potentially exists in many places. I think for now it would be okay to add the declaration to the test setup. Ok, I will take a look at this next week. Have a nice week Thanks for fixing that! Florian ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
RE: [Zope3-dev] Broken homefolder tests
Hi Florian [...] [...] No, this is usually painful tracking down. You could check for test setup code that assigns AttributeAnnotatable to File. Also note that there is no good way for tearing down classImplements() statements. So this issue potentially exists in many places. I think for now it would be okay to add the declaration to the test setup. Ok, I will take a look at this next week. Have a nice week Thanks for fixing that! no problem, that's not really your fault. It's a bad testing teardown concept in z3. We don't really teardown classImplements. This means in your situation the test where only broken if you run the test only for the homefolder package. But the z3 tests running all together where OK. I'm sure you tested the package before you did a commit. I recognized this only because I don't use the bugtracker in our setup. Regards Roger Ieichen Florian ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/dev%40projekt01.ch ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Broken homefolder tests
On Monday 06 February 2006 19:18, Roger Ineichen wrote: Does somebody know if there is a method for check if a teardown get called after a test? Some hints? No, this is usually painful tracking down. You could check for test setup code that assigns AttributeAnnotatable to File. Also note that there is no good way for tearing down classImplements() statements. So this issue potentially exists in many places. I think for now it would be okay to add the declaration to the test setup. Regards, Stephan -- Stephan Richter CBU Physics Chemistry (B.S.) / Tufts Physics (Ph.D. student) Web2k - Web Software Design, Development and Training ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
Re: [Zope3-dev] Broken homefolder tests
Am Dienstag, 7. Februar 2006 10:31 schrieb Stephan Richter: On Monday 06 February 2006 19:18, Roger Ineichen wrote: Does somebody know if there is a method for check if a teardown get called after a test? Some hints? No, this is usually painful tracking down. You could check for test setup code that assigns AttributeAnnotatable to File. Also note that there is no good way for tearing down classImplements() statements. So this issue potentially exists in many places. I think for now it would be okay to add the declaration to the test setup. Can I assume that the problem is not in the homefolder package? Florian ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
RE: [Zope3-dev] Broken homefolder tests
Hi Florian [...] No, this is usually painful tracking down. You could check for test setup code that assigns AttributeAnnotatable to File. Also note that there is no good way for tearing down classImplements() statements. So this issue potentially exists in many places. I think for now it would be okay to add the declaration to the test setup. Can I assume that the problem is not in the homefolder package? Sorry, but no you can't. One problem is, that the homefolder README test is broken because of, the File doesn't support AttributeAnnotatable by default. You can add directlyProvides(File, IAttributeAnnotatable) in the test setup. The bad thing is, that the test doesn't fail if you are running all tests at once. This means that another test provides IAttributeAnnotatable for the File. And this another test doesn't teardown correct. Regards Roger Ineichen Florian ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/dev%40projekt01.ch ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
RE: [Zope3-dev] Broken homefolder tests
Hi Stephan [...] No, this is usually painful tracking down. You could check for test setup code that assigns AttributeAnnotatable to File. Also note that there is no good way for tearing down classImplements() statements. So this issue potentially exists in many places. I think for now it would be okay to add the declaration to the test setup. Ok, I will take a look at this next week. Have a nice week Regards Roger Regards, Stephan -- Stephan Richter CBU Physics Chemistry (B.S.) / Tufts Physics (Ph.D. student) Web2k - Web Software Design, Development and Training ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
[Zope3-dev] Broken homefolder tests
Hi Florian, and other unittest gurus? The README.txt test in zope.app.homefolder is failing (trunk). This happens because the zope.app.file.file.File doesn't implement IAttributeAnnotatable in the test setup. The bad thing about this is, that the tests are running if you run all tests at once. This smells like a missing teardown in another test. Does somebody know if there is a method for check if a teardown get called after a test? Some hints? Regards Roger Ineichen ___ Zope3-dev mailing list Zope3-dev@zope.org Unsub: http://mail.zope.org/mailman/options/zope3-dev/archive%40mail-archive.com
