[Zorba-coders] [Bug 959833] Re: blocks in XQDoc have unequal spacing
** Attachment added: "As it ought to look." https://bugs.launchpad.net/zorba/+bug/959833/+attachment/2900989/+files/improved.png -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/959833 Title: blocks in XQDoc have unequal spacing Status in Zorba - The XQuery Processor: New Bug description: Given: (:~ : For example: : : if ( ft:stem( "apples" ) eq "apple" ) ** WRONG ** : : Instead do: : : if ( ft:stem( "apples" ) eq ft:stem( "apple" ) ) ** CORRECT ** : :) one gets what's shown in the attached screen-shot. As can be seen, there's more space below the line of code than above -- it should be equal. Additionally, the whitespace between the surrounding text should be increased -- see second attached screen-shot. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/959833/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 959833] Re: blocks in XQDoc have unequal spacing
** Attachment added: "Screen-shot unequal whitespace." https://bugs.launchpad.net/bugs/959833/+attachment/2900988/+files/Screen%20Shot%202012-03-19%20at%205.31.49%20PM.png -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/959833 Title: blocks in XQDoc have unequal spacing Status in Zorba - The XQuery Processor: New Bug description: Given: (:~ : For example: : : if ( ft:stem( "apples" ) eq "apple" ) ** WRONG ** : : Instead do: : : if ( ft:stem( "apples" ) eq ft:stem( "apple" ) ) ** CORRECT ** : :) one gets what's shown in the attached screen-shot. As can be seen, there's more space below the line of code than above -- it should be equal. Additionally, the whitespace between the surrounding text should be increased -- see second attached screen-shot. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/959833/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 959833] [NEW] blocks in XQDoc have unequal spacing
Public bug reported: Given: (:~ : For example: : : if ( ft:stem( "apples" ) eq "apple" ) ** WRONG ** : : Instead do: : : if ( ft:stem( "apples" ) eq ft:stem( "apple" ) ) ** CORRECT ** : :) one gets what's shown in the attached screen-shot. As can be seen, there's more space below the line of code than above -- it should be equal. Additionally, the whitespace between the surrounding text should be increased -- see second attached screen-shot. ** Affects: zorba Importance: Low Assignee: William Candillon (wcandillon) Status: New ** Tags: xqdoc -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/959833 Title: blocks in XQDoc have unequal spacing Status in Zorba - The XQuery Processor: New Bug description: Given: (:~ : For example: : : if ( ft:stem( "apples" ) eq "apple" ) ** WRONG ** : : Instead do: : : if ( ft:stem( "apples" ) eq ft:stem( "apple" ) ) ** CORRECT ** : :) one gets what's shown in the attached screen-shot. As can be seen, there's more space below the line of code than above -- it should be equal. Additionally, the whitespace between the surrounding text should be increased -- see second attached screen-shot. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/959833/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 957580] Re: stream read failure in StringToCodepointsIteartor
** Changed in: zorba Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/957580 Title: stream read failure in StringToCodepointsIteartor Status in Zorba - The XQuery Processor: Fix Committed Bug description: Executing the following query raises an '[zerr:ZOSE0003]: stream read failure' error in the StringToCodepointsIterator. let $n := myValue let $v := fn:serialize( $n/child::node(), http://www.w3.org/2010/xslt-xquery-serialization";> ) return fn:string-to-codepoints($v) To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/957580/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 959075] Re: serializer should accept/use Zorba_SerializerOptions
My comments are void if you don't want to make backwards-incompatible changes. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/959075 Title: serializer should accept/use Zorba_SerializerOptions Status in Zorba - The XQuery Processor: New Bug description: The Zorba API defines Zorba_SerializerOptions, which contains values for all known serialization parameters (and typedefs enums for all legal values for those parameters). It also contains a method to convert string parameters/values appropriately. The Zorba serializer (src/api/serialization/serializer.cpp) does not use this class, however. It defines an entirely redundant set of variables and enums for all these values, and an entirely redundant method to convert parameter/value strings. Then, there is src/api/serializerimpl.cpp, which contains methods to convert between those enums, but also ludicrously contains setSerializationParameters() which converts Zorba_SerializerOptions to internal serializer values by turning the enum values back into string parameter/value pairs and passing them to the internal serializer. This is a great deal of wasted code, and it makes adding new serialization parameters a nightmare. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/959075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Bug 959075] Re: serializer should accept/use Zorba_SerializerOptions
> > - The Zorba_SerializerOptions are also used in the C API. > Do you mean the C++ API, or literally the C API? I don't recall it in XQC... (relevant because I'd like to have it throw exceptions for bad values) If you mean "don't make any backwards-incompatible changes", then yes, understood - my intent is to eliminate the internal redundancy and leave the existing public API as it is. - The encodings parameter should be an arbitrary string to allow for more > encodings than utf8 and utf816. This would be a backwards-incompatible change, most likely, and so would have to wait for Zorba 3.0. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/959075 Title: serializer should accept/use Zorba_SerializerOptions Status in Zorba - The XQuery Processor: New Bug description: The Zorba API defines Zorba_SerializerOptions, which contains values for all known serialization parameters (and typedefs enums for all legal values for those parameters). It also contains a method to convert string parameters/values appropriately. The Zorba serializer (src/api/serialization/serializer.cpp) does not use this class, however. It defines an entirely redundant set of variables and enums for all these values, and an entirely redundant method to convert parameter/value strings. Then, there is src/api/serializerimpl.cpp, which contains methods to convert between those enums, but also ludicrously contains setSerializationParameters() which converts Zorba_SerializerOptions to internal serializer values by turning the enum values back into string parameter/value pairs and passing them to the internal serializer. This is a great deal of wasted code, and it makes adding new serialization parameters a nightmare. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/959075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-957580 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-957580 into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-957580/+merge/98227 -- https://code.launchpad.net/~zorba-coders/zorba/bug-957580/+merge/98227 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-957580 into lp:zorba
Validation queue job bug-957580-2012-03-19T17-15-59.922Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-957580/+merge/98227 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-957580 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-957580-2012-03-19T17-15-59.922Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-957580/+merge/98227 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-957580 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-957580 into lp:zorba has been updated. Commit Message changed to: fixed bug #957580 (stream read failure in StringToCodepointsIteartor) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-957580/+merge/98227 -- https://code.launchpad.net/~zorba-coders/zorba/bug-957580/+merge/98227 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-957580 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-957580 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-957580/+merge/98227 -- https://code.launchpad.net/~zorba-coders/zorba/bug-957580/+merge/98227 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-957580 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-957580/+merge/98227 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 957580] Re: stream read failure in StringToCodepointsIteartor
** Changed in: zorba Milestone: None => 2.2 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/957580 Title: stream read failure in StringToCodepointsIteartor Status in Zorba - The XQuery Processor: In Progress Bug description: Executing the following query raises an '[zerr:ZOSE0003]: stream read failure' error in the StringToCodepointsIterator. let $n := myValue let $v := fn:serialize( $n/child::node(), http://www.w3.org/2010/xslt-xquery-serialization";> ) return fn:string-to-codepoints($v) To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/957580/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/module-schema-tools into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98224 -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98224 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 3 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98224 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba
Validation queue job module-schema-tools-2012-03-19T16-20-06.136Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98224 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 957580] Re: stream read failure in StringToCodepointsIteartor
** Changed in: zorba Status: New => In Progress -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/957580 Title: stream read failure in StringToCodepointsIteartor Status in Zorba - The XQuery Processor: In Progress Bug description: Executing the following query raises an '[zerr:ZOSE0003]: stream read failure' error in the StringToCodepointsIterator. let $n := myValue let $v := fn:serialize( $n/child::node(), http://www.w3.org/2010/xslt-xquery-serialization";> ) return fn:string-to-codepoints($v) To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/957580/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-957580 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-957580/+merge/98227 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-957580 into lp:zorba
Paul J. Lucas has proposed merging lp:~zorba-coders/zorba/bug-957580 into
lp:zorba.
Requested reviews:
Paul J. Lucas (paul-lucas)
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #957580 in Zorba: "stream read failure in StringToCodepointsIteartor"
https://bugs.launchpad.net/zorba/+bug/957580
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-957580/+merge/98227
Fixed EOF handling.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-957580/+merge/98227
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/runtime/spec/strings/strings.xml'
--- src/runtime/spec/strings/strings.xml 2012-01-18 13:57:48 +
+++ src/runtime/spec/strings/strings.xml 2012-03-19 16:32:45 +
@@ -59,6 +59,7 @@
+
=== modified file 'src/runtime/strings/pregenerated/strings.h'
--- src/runtime/strings/pregenerated/strings.h 2012-01-18 13:57:48 +
+++ src/runtime/strings/pregenerated/strings.h 2012-03-19 16:32:45 +
@@ -83,6 +83,7 @@
xs_unsignedInt theIterator; //the current iterator
checked_vector theResult; //the resulting vector
std::istream* theStream; //
+ store::Item_t theStreamItem; //
StringToCodepointsIteratorState();
=== modified file 'src/runtime/strings/strings_impl.cpp'
--- src/runtime/strings/strings_impl.cpp 2012-02-29 11:10:30 +
+++ src/runtime/strings/strings_impl.cpp 2012-03-19 16:32:45 +
@@ -126,13 +126,14 @@
}
else
{
+ state->theStreamItem = item;
state->theStream = &item->getStream();
}
}
if ( state->theStream )
{
-while ( !state->theStream->eof() )
+while ( true )
{
utf8::encoded_char_type ec;
memset( ec, 0, sizeof( ec ) );
@@ -141,6 +142,8 @@
if ( utf8::read( *state->theStream, ec ) == utf8::npos )
{
+if ( state->theStream->eof() )
+ break;
if ( state->theStream->good() ) {
//
// If read() failed but the stream state is good, it means that an
@@ -212,6 +215,7 @@
PlanIteratorState::reset(planState);
theIterator = 0;
theResult.clear();
+ theStreamItem = 0;
}
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba
I didn't know Markos removed the scripts after I made the changes. But I removed the comment and I fixed the indentation of init_val lines. I also fixed the ExternalModules.config wrong merge, and checked src/system/zorba_properties.h contains changes only related to CLASSPATH and indentation. -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98224 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/module-schema-tools into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98224 -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98224 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/module-schema-tools-2012-03-19T16-20-06.136Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98224 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-schema-tools into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/module-schema-tools into lp:zorba has been updated. Commit Message changed to: Add java classpath to zorbacmd and to Zorba API. Fix dynamic libraries loading. Tested it works on Windows with both xsl-fo and xmlbeans modules. All tests are passing. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98224 -- https://code.launchpad.net/~zorba-coders/zorba/module-schema-tools/+merge/98224 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 959075] Re: serializer should accept/use Zorba_SerializerOptions
When changing this, please keep the following two things in mind: - The Zorba_SerializerOptions are also used in the C API. - The encodings parameter should be an arbitrary string to allow for more encodings than utf8 and utf816. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/959075 Title: serializer should accept/use Zorba_SerializerOptions Status in Zorba - The XQuery Processor: New Bug description: The Zorba API defines Zorba_SerializerOptions, which contains values for all known serialization parameters (and typedefs enums for all legal values for those parameters). It also contains a method to convert string parameters/values appropriately. The Zorba serializer (src/api/serialization/serializer.cpp) does not use this class, however. It defines an entirely redundant set of variables and enums for all these values, and an entirely redundant method to convert parameter/value strings. Then, there is src/api/serializerimpl.cpp, which contains methods to convert between those enums, but also ludicrously contains setSerializationParameters() which converts Zorba_SerializerOptions to internal serializer values by turning the enum values back into string parameter/value pairs and passing them to the internal serializer. This is a great deal of wasted code, and it makes adding new serialization parameters a nightmare. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/959075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 959079] [NEW] Zorba_SerializerOptions should not silently ignore invalid parameter values
Public bug reported: Zorba_SerializerOptions::SetSerializerOption() converts string parameter/value pairs to enumerated values. It perforce checks for all possible valid parameter names, and all valid values for each parameter. However, it silently ignores any invalid parameter names or values. This method is tied directly to the Zorba's -z (--serialization-parameter) command-line options, which means that any typos on the command line silently do nothing. eg, zorba -q '1' -z undeclare-prefixes=foo reports no error; nor does zorba -q '1' -z indeclare-prefixes=yes ** Affects: zorba Importance: Medium Assignee: Chris Hillery (ceejatec) Status: New ** Changed in: zorba Assignee: (unassigned) => Chris Hillery (ceejatec) ** Changed in: zorba Importance: Undecided => Medium -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/959079 Title: Zorba_SerializerOptions should not silently ignore invalid parameter values Status in Zorba - The XQuery Processor: New Bug description: Zorba_SerializerOptions::SetSerializerOption() converts string parameter/value pairs to enumerated values. It perforce checks for all possible valid parameter names, and all valid values for each parameter. However, it silently ignores any invalid parameter names or values. This method is tied directly to the Zorba's -z (--serialization-parameter) command-line options, which means that any typos on the command line silently do nothing. eg, zorba -q '1' -z undeclare-prefixes=foo reports no error; nor does zorba -q '1' -z indeclare-prefixes=yes To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/959079/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 959075] [NEW] serializer should accept/use Zorba_SerializerOptions
Public bug reported: The Zorba API defines Zorba_SerializerOptions, which contains values for all known serialization parameters (and typedefs enums for all legal values for those parameters). It also contains a method to convert string parameters/values appropriately. The Zorba serializer (src/api/serialization/serializer.cpp) does not use this class, however. It defines an entirely redundant set of variables and enums for all these values, and an entirely redundant method to convert parameter/value strings. Then, there is src/api/serializerimpl.cpp, which contains methods to convert between those enums, but also ludicrously contains setSerializationParameters() which converts Zorba_SerializerOptions to internal serializer values by turning the enum values back into string parameter/value pairs and passing them to the internal serializer. This is a great deal of wasted code, and it makes adding new serialization parameters a nightmare. ** Affects: zorba Importance: Medium Assignee: Chris Hillery (ceejatec) Status: New ** Changed in: zorba Importance: Undecided => Medium ** Changed in: zorba Assignee: (unassigned) => Chris Hillery (ceejatec) -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/959075 Title: serializer should accept/use Zorba_SerializerOptions Status in Zorba - The XQuery Processor: New Bug description: The Zorba API defines Zorba_SerializerOptions, which contains values for all known serialization parameters (and typedefs enums for all legal values for those parameters). It also contains a method to convert string parameters/values appropriately. The Zorba serializer (src/api/serialization/serializer.cpp) does not use this class, however. It defines an entirely redundant set of variables and enums for all these values, and an entirely redundant method to convert parameter/value strings. Then, there is src/api/serializerimpl.cpp, which contains methods to convert between those enums, but also ludicrously contains setSerializationParameters() which converts Zorba_SerializerOptions to internal serializer values by turning the enum values back into string parameter/value pairs and passing them to the internal serializer. This is a great deal of wasted code, and it makes adding new serialization parameters a nightmare. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/959075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
