Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/php_windows_fix into lp:zorba

2013-10-22 Thread Juan Zacarias 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/php_windows_fix/+merge/192253
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/php_windows_fix into lp:zorba

2013-10-22 Thread Juan Zacarias 
Juan Zacarias has proposed merging lp:~zorba-coders/zorba/php_windows_fix into 
lp:zorba.

Commit message:
Solved Linker error when building the php bindings.

Requested reviews:
  Juan Zacarias (juan457)
  Chris Hillery (ceejatec)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/php_windows_fix/+merge/192253

Solved Linker error when building the php bindings.
-- 
https://code.launchpad.net/~zorba-coders/zorba/php_windows_fix/+merge/192253
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'include/zorba/internal/diagnostic.h'
--- include/zorba/internal/diagnostic.h	2013-09-13 21:42:43 +
+++ include/zorba/internal/diagnostic.h	2013-10-22 21:42:17 +
@@ -262,9 +262,7 @@
  * @param j The second location.
  * @return Returns \c true only if the two locations are not equal.
  */
-inline bool operator!=( location const i, location const j ) {
-  return !(i == j);
-}
+bool operator!=( location const i, location const j );
 
 ///
 

=== modified file 'src/diagnostics/diagnostic.cpp'
--- src/diagnostics/diagnostic.cpp	2013-09-13 21:43:08 +
+++ src/diagnostics/diagnostic.cpp	2013-10-22 21:42:17 +
@@ -66,6 +66,7 @@
ztd::equals( q1.ns(), q2.ns() );
 }
 
+
 bool operator==( QName const q1, char const *q2 ) {
   if ( q2 ) {
 if ( *q2 == '{' ) {
@@ -148,6 +149,10 @@
i.column_end_ == j.column_end_;
 }
 
+bool operator!=( location const i, location const j ) {
+  return !(i == j);
+}
+
 parameters const parameters::empty;
 
 #define case_123456789 \

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/php_windows_fix into lp:zorba

2013-10-22 Thread Chris Hillery 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/php_windows_fix/+merge/192253
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/php_windows_fix into lp:zorba

2013-10-22 Thread Chris Hillery 
The proposal to merge lp:~zorba-coders/zorba/php_windows_fix into lp:zorba has 
been updated.

Description changed to:

Solved Linker error when building the php bindings.
https://code.launchpad.net/~zorba-coders/zorba/process_windows_fix/+merge/192252
https://code.launchpad.net/~zorba-coders/zorba/archive_windows_fix/+merge/192251

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/php_windows_fix/+merge/192253
-- 
https://code.launchpad.net/~zorba-coders/zorba/php_windows_fix/+merge/192253
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/php_windows_fix into lp:zorba

2013-10-22 Thread Zorba Build Bot 
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/php_windows_fix/+merge/192253
https://code.launchpad.net/~zorba-coders/zorba/process_windows_fix/+merge/192252
https://code.launchpad.net/~zorba-coders/zorba/archive_windows_fix/+merge/192251

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/php_windows_fix/+merge/192253
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/php_windows_fix into lp:zorba

2013-10-22 Thread noreply 
The proposal to merge lp:~zorba-coders/zorba/php_windows_fix into lp:zorba has 
been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/php_windows_fix/+merge/192253
-- 
https://code.launchpad.net/~zorba-coders/zorba/php_windows_fix/+merge/192253
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/php_windows_fix into lp:zorba

2013-10-22 Thread Zorba Build Bot 
Validation queue succeeded - proposal merged!
-- 
https://code.launchpad.net/~zorba-coders/zorba/php_windows_fix/+merge/192253
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp