Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/xqj_installers into lp:zorba has been updated. Commit Message changed to: - Install added for XQJ bindings and documentation - more documentation for all SWIG generated language bindings - other installer related cleanups For more details, see: https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/xqj_installers into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/xqj_installers-2012-06-12T22-18-09.524Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Validation queue job xqj_installers-2012-06-12T22-18-09.524Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/xqj_installers into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Review: Needs Fixing make make install on a clean build directory gives the following error: CMake Error at swig/java/cmake_install.cmake:38 (FILE): file INSTALL cannot find /home/mbrantner/zorba/build/swig/java/libzorba_api.so. Call Stack (most recent call first): swig/cmake_install.cmake:39 (INCLUDE) cmake_install.cmake:46 (INCLUDE) -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Review: Needs Fixing Mostly looks excellent. I still think the SITEARCH issue is a problem, but I see that it also exists in the Java SWIG code as Rodolfo says, so I will file a separate bug report about that. The only change I would request: Rodolfo, in swig/xqj/CMakeLists.txt, you have separate code using the new CMake UseJava functionality if the CMake version is greater than 2.8.6. I like that, because the ADD_CUSTOM_COMMAND(POST_BUILD) technique used otherwise is a kludge that doesn't get the dependencies right. Could you also use that same UseJava technique in swig/java/CMakeLists.txt ? -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
I copied the code from Java Binding... I think this must be changed on both sides, the change must implicate the JAR generation for both bindings.. -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Rodolfo Ochoa has proposed merging lp:~zorba-coders/zorba/xqj_installers into
lp:zorba.
Requested reviews:
Juan Zacarias (juan457)
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257
Install added for XQJ layer
--
https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'doc/CMakeLists.txt'
--- doc/CMakeLists.txt 2012-05-03 12:31:51 +
+++ doc/CMakeLists.txt 2012-05-31 22:43:20 +
@@ -91,6 +91,10 @@
INSTALL(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/ruby/html
COMPONENT doc
DESTINATION share/doc/zorba-${ZORBA_MAJOR_NUMBER}.${ZORBA_MINOR_NUMBER}.${ZORBA_PATCH_NUMBER}/ruby)
+
+ INSTALL(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/xqj/html
+COMPONENT doc
+DESTINATION share/doc/zorba-${ZORBA_MAJOR_NUMBER}.${ZORBA_MINOR_NUMBER}.${ZORBA_PATCH_NUMBER}/xqj)
ENDIF (SWIG_FOUND)
INSTALL(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/zorba/html
=== modified file 'swig/xqj/CMakeLists.txt'
--- swig/xqj/CMakeLists.txt 2012-05-03 12:31:51 +
+++ swig/xqj/CMakeLists.txt 2012-05-31 22:43:20 +
@@ -81,6 +81,13 @@
SET_TESTS_PROPERTIES(swig_xqj PROPERTIES FAIL_REGULAR_EXPRESSION Failures;Errors)
ENDIF(WIN32)
+ # Install section
+ FILE(GLOB XQJ_SWIG_FILES ${CMAKE_CURRENT_BINARY_DIR}/*.java)
+ IF(NOT WIN32)
+INSTALL(FILES ${XQJ_SWIG_FILES} DESTINATION ${JAVA_SITEARCH_DIR})
+ ELSE(NOT WIN32)
+INSTALL(FILES ${XQJ_SWIG_FILES} DESTINATION share/xqj COMPONENT XQJ Binding)
+ ENDIF(NOT WIN32)
ELSE (JAVA_INCLUDE_PATH)
MESSAGE ( STATUS SWIG Java: Not generating XQJ API because JNI headers not found.)
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Review: Needs Information If Zorba is not being installed in /usr/local, that does not necessarily mean that it IS being installed in the same directory hierarchy as Java. I don't like that assumption in swig/xqj/CMakeLists.txt. Is there not any way with FIND_PACKAGE(Java) to determine the SITEARCH directory? That information must exist somewhere. Also, in /usr/share/java on my Ubuntu system, there are no .java files, only .jar files. Did you really intend to install .java files there? -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
