Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Review: Needs Fixing make make install on a clean build directory gives the following error: CMake Error at swig/java/cmake_install.cmake:38 (FILE): file INSTALL cannot find /home/mbrantner/zorba/build/swig/java/libzorba_api.so. Call Stack (most recent call first): swig/cmake_install.cmake:39 (INCLUDE) cmake_install.cmake:46 (INCLUDE) -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Review: Needs Fixing Mostly looks excellent. I still think the SITEARCH issue is a problem, but I see that it also exists in the Java SWIG code as Rodolfo says, so I will file a separate bug report about that. The only change I would request: Rodolfo, in swig/xqj/CMakeLists.txt, you have separate code using the new CMake UseJava functionality if the CMake version is greater than 2.8.6. I like that, because the ADD_CUSTOM_COMMAND(POST_BUILD) technique used otherwise is a kludge that doesn't get the dependencies right. Could you also use that same UseJava technique in swig/java/CMakeLists.txt ? -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
I copied the code from Java Binding... I think this must be changed on both sides, the change must implicate the JAR generation for both bindings.. -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqj_installers into lp:zorba
Review: Needs Information If Zorba is not being installed in /usr/local, that does not necessarily mean that it IS being installed in the same directory hierarchy as Java. I don't like that assumption in swig/xqj/CMakeLists.txt. Is there not any way with FIND_PACKAGE(Java) to determine the SITEARCH directory? That information must exist somewhere. Also, in /usr/share/java on my Ubuntu system, there are no .java files, only .jar files. Did you really intend to install .java files there? -- https://code.launchpad.net/~zorba-coders/zorba/xqj_installers/+merge/108257 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
