Re: [OpenJDK 2D-Dev] Thoughts about font implementation

2008-10-14 Thread Roman Kennke
Hi there, What do you think about this patch (see webrev link below)? Can we get this into jdk7? It is very useful for me and I wouldn't like to maintain it myself... Cheers, Roman > http://kennke.org/~roman/truetypefrombuffer/webrev/ -- http://kennke.org/blog/ signature.asc Description: Die

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

2008-10-14 Thread Igor Nekrestyanov
Am i understanding this correctly and this adds new TrueType constructor that is not used in the OpenJDK itself? -igor Roman Kennke wrote: Hi there, What do you think about this patch (see webrev link below)? Can we get this into jdk7? It is very useful for me and I wouldn't like to maintain

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

2008-10-14 Thread Roman Kennke
> Am i understanding this correctly and this adds new TrueType constructor > that is not used in the OpenJDK itself? For now, yes. (I'm using this in my own FontManager implementation in the JamaicaVM, to load fonts from ROM instead of files. But this requires the FontManager refactoring in Cacio

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

2008-10-14 Thread Igor Nekrestyanov
Minimal changes are always good idea. However, we usually do not add new methods unless we actually use them. Not sure what's the best approach in this case. -igor Roman Kennke wrote: Am i understanding this correctly and this adds new TrueType constructor that is not used in the OpenJDK itself

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

2008-10-14 Thread Mario Torre
Il giorno mer, 15/10/2008 alle 01.43 +0400, Igor Nekrestyanov ha scritto: > Minimal changes are always good idea. > However, we usually do not add new methods unless we actually use them. > Not sure what's the best approach in this case. > > -igor Hi Igor! I agree, but these methods will serve a

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

2008-10-14 Thread Roman Kennke
Hi Igor, > Minimal changes are always good idea. > However, we usually do not add new methods unless we actually use them. > Not sure what's the best approach in this case. Maybe we should give you the FontManager work first (it's not finished yet, I have to test and fix on Windows first - this i