Re: [OpenJDK 2D-Dev] openjdk incompatibility

2008-10-18 Thread Phil Race
You didn't show what the result was from OpenJDK Seems the complaint here is the that the position of the vertical bounds is suspect. Looks like the sign is incorrect in some code that interfaces to freetype and returns glyph bounds I think bbox.yMax should be -bbox.yMax, since freetype consid

Re: [OpenJDK 2D-Dev] [PATCH] FontManager refactoring

2008-10-18 Thread Igor Nekrestyanov
Wow, that's the large one. It will take some time for me to look through this and Phil is the right guy to review most of these changes anyway. Just few small comments for now. I see that in number of places static variables are upper case. E.g. number of variables in the FontUtilities. I am n

Re: [OpenJDK 2D-Dev] JNI crashes in FontManager code

2008-10-18 Thread Igor Nekrestyanov
Hello Martin, Suggested changes seems reasonable. However, i failed to invent testcase to reproduce this issue. Could you please describe what google test is doing in regard to the font code? It first glance it seems that the only way to get into freetypeScaler.c is through synchronized metho