Re: [OpenJDK 2D-Dev] Bug fixes for com.sun.imageio.plugins.png.PNGMetadata

2008-11-10 Thread Igor Nekrestyanov
Hi Martin, yes, this is correct list for ImageIO fixes. I am not ImageIO expert and someone who better understands this code will need to review this. If changes are ok then we will integrate it acknowledging your contribution. Usually it is more convenient to deal with independent issues se

[OpenJDK 2D-Dev] 6541476 (Eval): PNG imageio plugin incorrectly handles iTXt chunk

2008-11-10 Thread Martin von Gagern
Bug 6541476; State: 8-Fix Available, bug; Priority: 4-Low http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6541476 This is the second half od the issues mentioned in bug report 6541476. While my previous post for this bug number concentrated on the metadata class and the use of typesafe generics

[OpenJDK 2D-Dev] 5082756: Image I/O plug-ins set metadata boolean attributes to "true" or "false"

2008-11-10 Thread Martin von Gagern
Bug ID: 5082756; State: 6-Fix Understood, bug; Priority: 4-Low http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5082756 While the DTDs for the different metdata formats usually specify boolean values as ( "TRUE" | "FALSE" ), the implementations tend to use "true" and "false" instead. There are

[OpenJDK 2D-Dev] 5106550: PNG writer merge standard metadata fails for TextEntry sans #IMPLIED attributes

2008-11-10 Thread Martin von Gagern
Bug ID: 5106550; State: 3-Accepted, bug; Priority: 4-Low http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5106550 The bug lies in the fact that for TextEntry nodes in standard metadata format, PNGMetadata requires additional attributes besides the ones marked #REQUIRED in the DTD. Namely missing

[OpenJDK 2D-Dev] 6541476: PNG imageio plugin incorrectly handles iTXt chunk

2008-11-10 Thread Martin von Gagern
Bug 6541476; State: 8-Fix Available, bug; Priority: 4-Low http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6541476 PNGMetadata is inconsitent in what data types get stored in its various iTXt_* lists. Method mergeNativeTree used different data types than the rest of the code for the following tw