Re: [OpenJDK 2D-Dev] [PATCH] FontManager refactoring

2009-01-15 Thread Roman Kennke
Hi Phil, > I've only gone through maybe 35-40% of the changes but here's my comments > so far : > > PhysicalFont.java : US_LCID better belongs in TrueTypeFont.java > since you moved the only uses of it to that file. Yeah right. I'll fix. > Since you are touching this, and so much else, maybe th

Re: [OpenJDK 2D-Dev] XOR rendering slow with D3D enabled [6635462]

2009-01-15 Thread David Gilbert
Dmitri Trembovetski wrote: IMO if it takes too long to draw a chart it needs to be cached in an image (VolatileImage, for example). That is an option that is provided in JFreeChart, and so we'll modify our code to *not* use XOR in that case. But XOR saves us from having to allocate that

Re: [OpenJDK 2D-Dev] XOR rendering slow with D3D enabled [6635462]

2009-01-15 Thread Dmitri Trembovetski
David Gilbert wrote: Clemens Eisserer wrote: It hasn't. The default mode is not outline AFAIK. So if you enabled outline, it's all your fault! I disagree here, Swing does provide the outline mode as a public API, it worked great in the past and now its broken. Its not deprecated, not e

Re: [OpenJDK 2D-Dev] XOR rendering slow with D3D enabled [6635462]

2009-01-15 Thread Dmitri Trembovetski
Clemens Eisserer wrote: It hasn't. The default mode is not outline AFAIK. So if you enabled outline, it's all your fault! I disagree here, Swing does provide the outline mode as a public API, it worked great in the past and now its broken. In case it wasn't clear, I was joking. Dmitri

Re: [OpenJDK 2D-Dev] XOR rendering slow with D3D enabled [6635462]

2009-01-15 Thread David Gilbert
Clemens Eisserer wrote: It hasn't. The default mode is not outline AFAIK. So if you enabled outline, it's all your fault! I disagree here, Swing does provide the outline mode as a public API, it worked great in the past and now its broken. Its not deprecated, not even mentioned in the doc

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6788096: ImageIO SreamCloser causes memory leak in FX applets

2009-01-15 Thread andrew . brygin
Changeset: 774083387e81 Author:bae Date: 2009-01-15 13:55 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/774083387e81 6788096: ImageIO SreamCloser causes memory leak in FX applets Reviewed-by: igor, prr ! src/share/classes/com/sun/imageio/stream/StreamCloser.java + test/java

Re: [OpenJDK 2D-Dev] XOR rendering slow with D3D enabled [6635462]

2009-01-15 Thread Clemens Eisserer
> It hasn't. The default mode is not outline AFAIK. So if you enabled > outline, it's all your fault! I disagree here, Swing does provide the outline mode as a public API, it worked great in the past and now its broken. Its not deprecated, not even mentioned in the documentation that it should be