Re: [OpenJDK 2D-Dev] miter line join bug

2009-02-18 Thread Phil Race
Without verifying the proposed fix itself, the problem I see here is that this test doesn't appear to be automated. See the one for the dashed line bug for ideas on automation. For the record: we require that tests be provided and automated if at all feasible, or there must be a justification wh

[OpenJDK 2D-Dev] miter line join bug

2009-02-18 Thread Hiroshi Yamauchi
Hi, Here's a miter bugfix, and a test. Thanks, Hiroshi bug The miter line join decoration isn't rendered properly. fix +++ jdk/src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java 2009-02-18 17:14:05.0 -0800 @@ -245,6 +245,7 @@

Re: [OpenJDK 2D-Dev] Dashed line bug

2009-02-18 Thread Dmitri Trembovetski
Hiroshi Yamauchi wrote: Aha. Can someone point me to the Mercurial changeset URL of the patch? I'd like to use the existing patch. As per earlier Phil's email which pointed to this post: http://mail.openjdk.java.net/pipermail/2d-dev/2009-January/000651.html the revision is http://

Re: [OpenJDK 2D-Dev] Dashed line bug

2009-02-18 Thread Hiroshi Yamauchi
Aha. Can someone point me to the Mercurial changeset URL of the patch? I'd like to use the existing patch. Thanks! On Wed, Feb 18, 2009 at 9:17 AM, Phil Race wrote: > Yes, its the same bug. http://bugs.sun.com/view_bug.do?bug_id=6793344 > > Its fixed in the 2D repo on openjdk, but isn't yet inte

Re: [OpenJDK 2D-Dev] Dashed line bug

2009-02-18 Thread Hiroshi Yamauchi
Thanks, Phil. On Wed, Feb 18, 2009 at 12:20 PM, Phil Race wrote: > http://mail.openjdk.java.net/pipermail/2d-dev/2009-January/000651.html > > -phil. > > Hiroshi Yamauchi wrote: >> >> Aha. Can someone point me to the Mercurial changeset URL of the patch? >> I'd like to use the existing patch. >> >

Re: [OpenJDK 2D-Dev] Dashed line bug

2009-02-18 Thread Phil Race
http://mail.openjdk.java.net/pipermail/2d-dev/2009-January/000651.html -phil. Hiroshi Yamauchi wrote: Aha. Can someone point me to the Mercurial changeset URL of the patch? I'd like to use the existing patch. Thanks! On Wed, Feb 18, 2009 at 9:17 AM, Phil Race wrote: Yes, its the same bug. h

Re: [OpenJDK 2D-Dev] Dashed line bug

2009-02-18 Thread Phil Race
Yes, its the same bug. http://bugs.sun.com/view_bug.do?bug_id=6793344 Its fixed in the 2D repo on openjdk, but isn't yet integrated into jdk7 master. -phil. Omair Majid wrote: Mark Wielaard wrote: Hi Hiroshi, On Tue, 2009-02-17 at 16:04 -0800, Hiroshi Yamauchi wrote: I think I found a bug i

Re: [OpenJDK 2D-Dev] Dashed line bug

2009-02-18 Thread Omair Majid
Mark Wielaard wrote: Hi Hiroshi, On Tue, 2009-02-17 at 16:04 -0800, Hiroshi Yamauchi wrote: I think I found a bug in the dashed line rendering (i.e., an incompatibility with Sun JDK) and a fix with a test. The problem was the difference in the interpretation of the float array which defines the

Re: [OpenJDK 2D-Dev] Dashed line bug

2009-02-18 Thread Mark Wielaard
Hi Hiroshi, On Tue, 2009-02-17 at 16:04 -0800, Hiroshi Yamauchi wrote: > I think I found a bug in the dashed line rendering (i.e., an > incompatibility with Sun JDK) and a fix with a test. > The problem was the difference in the interpretation of the float > array which defines the pattern of dash