Re: [OpenJDK 2D-Dev] Question regarding surface locking

2009-03-24 Thread Roman Kennke
Yeah right, I just answered this myself after I wrote it. At least for XPixmaps this makes sense. Could be optimized for Shm and DGA I suppose, but that would complicate stuff (even more), unless the implementation gets split up in XPixmapSurfaceData, ShmSurfaceData and DGASurfaceData or so. /Roma

Re: [OpenJDK 2D-Dev] Question regarding surface locking

2009-03-24 Thread Clemens Eisserer
Hi Roman, > Is it really necessary to lock on a global lock, wouldn't a > lock on the surface do the same job? I'm thinking when you have > animations on several surfaces in parallel (like in the Java2Demo), it > might be more efficient to have a finer grained lock. Or are there other > pitfalls a

[OpenJDK 2D-Dev] Question regarding surface locking

2009-03-24 Thread Roman Kennke
Hi there, I see in X11SurfaceData, that we lock and unlock on the global AWT lock. AFAICS, the purpose of this lock is to prevent race conditions on the surface data (like: t1 reads, t2 reads, t1 writes back, t2 writes back -> BUMM). Is it really necessary to lock on a global lock, wouldn't a lock

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6821504: typo in lcmsio.c

2009-03-24 Thread phil . race
Changeset: 0c69e3ba15f4 Author:prr Date: 2009-03-24 10:53 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/0c69e3ba15f4 6821504: typo in lcmsio.c Reviewed-by: jgodinez ! src/share/native/sun/java2d/cmm/lcms/cmsio0.c

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6821031: Upgrade OpenJDK's LittleCMS version to 1.18

2009-03-24 Thread phil . race
Changeset: e2cc7ffbb355 Author:prr Date: 2009-03-24 09:14 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e2cc7ffbb355 6821031: Upgrade OpenJDK's LittleCMS version to 1.18 Reviewed-by: bae, igor ! src/share/native/sun/java2d/cmm/lcms/LCMS.c ! src/share/native/sun/java2d/cmm/l