Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-06-18 Thread Jim Graham
Whoops! I abbreviated and sent you off on a wild goose chase. There are many different loops! There just happen to be (I think!?) only 1 kind of *TEXT* loop in the system for a given surface. I left out that qualifier below and misdirected you. Thus, if the text loops were split out then i

Re: [OpenJDK 2D-Dev] [PATCH] FontManager refactoring, rev5

2009-06-18 Thread Phil Race
Roman, Looks close. Just a few comments. you aren't using these import in sun.font.FontManager : 30 import java.util.Locale; 31 import java.util.TreeMap; 32 33 import javax.swing.plaf.FontUIResource; There may be other such cases but its easy to see in this much reduced file. SunGraph

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-06-18 Thread Mario Torre
Il giorno gio, 18/06/2009 alle 17.36 -0400, Roman Kennke ha scritto: > Hi folks, > > The thing is, it might be the case that we only have one loops thing in > the pipelines we have in OpenJDK, but thanks to Cacio (hohum) we must > consider that there are other implementations out there... which

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-06-18 Thread Roman Kennke
Hi folks, The thing is, it might be the case that we only have one loops thing in the pipelines we have in OpenJDK, but thanks to Cacio (hohum) we must consider that there are other implementations out there... which might want to take completely different approaches. So better to keep it clea

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-06-18 Thread Mario Torre
Il giorno gio, 18/06/2009 alle 16.01 -0400, Roman Kennke ha scritto: > Hi Jim, > > If only one instance of the loops is used during the lifetime of a > Surface, then we can easily keep this instance there instead of the > SG2D, validating would not initialize any new objects, but only put > stu

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-06-18 Thread Roman Kennke
Hi Jim, If only one instance of the loops is used during the lifetime of a Surface, then we can easily keep this instance there instead of the SG2D, validating would not initialize any new objects, but only put stuff together that is already present in the SurfaceData anyway. Or did I get som

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-06-18 Thread Jim Graham
That makes a lot of sense since I think the introduction of the GlyphListLoopPipe in its current form was where the original methodology of "always install loops if you plan to use loops" was first (and only time) violated. I think I raised the issue at the time and Phil pointed out that, in

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-06-18 Thread Mario Torre
Il giorno gio, 18/06/2009 alle 00.34 +0200, Mario Torre ha scritto: > But I'll debafterug it a little further and send you some updates asap. > > Cheers, > Mario Hello! The pipelines that use a loops after being invalidated without checking if it's valid or not (null) are those so far: LCDText