Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Mario Torre
Il 23/06/2009 23:51, Roman Kennke ha scritto: Hi, Someone would need to make darn sure that ALL uses of the old name have been changed. I counted 362 references to this variable in the openjdk7 repositories, I assume a similar number in openjdk6. The closed jdk sources have an additional 13 ref

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Mario Torre
Il 23/06/2009 23:37, Phil Race ha scritto: Ah, everyone must be looking at the old (1.16) lcms that we replaced quite a few builds ago. It didn't have the #if macintosh Whoops... I admit that we depend on a slightly older OpenJDK version, and this time I didn't checked the latest code :) I ju

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Roman Kennke
Hi, Someone would need to make darn sure that ALL uses of the old name have been changed. I counted 362 references to this variable in the openjdk7 repositories, I assume a similar number in openjdk6. The closed jdk sources have an additional 13 references to this _LITTLE_ENDIAN name Sun would n

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Kelly O'Hair
Someone would need to make darn sure that ALL uses of the old name have been changed. I counted 362 references to this variable in the openjdk7 repositories, I assume a similar number in openjdk6. The closed jdk sources have an additional 13 references to this _LITTLE_ENDIAN name Sun would need to

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Phil Race
Roman Kennke wrote: Hi, first of all, I think this is a LCMS problem, so we should think about how to fix this _upstream_, otherwise we end up maintaining a patched version of lcms *shudder*. But I see only that in the lcms.h file. And it is protected inside #if macintosh so I can't believ

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Roman Kennke
Hi, first of all, I think this is a LCMS problem, so we should think about how to fix this _upstream_, otherwise we end up maintaining a patched version of lcms *shudder*. Then I don't think it's a good idea to depend on such 'internal' defines. One OS defines or not _LITTLE_ENDIAN, others (

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Kelly O'Hair
Mario Torre wrote: Hello all! I have a problem with a block of code that checks if _LITTLE_ENDIAN is defined, the code is in little cms and looks like: #ifndef _LITTLE_ENDIAN #define USE_BIG_ENDIAN 1 #endif The issue that I have is that on VxWorks, the target I'm working on, there is al

Re: [OpenJDK 2D-Dev] upcoming 2d JDK 7 integration

2009-06-23 Thread Jennifer Godinez
Reminder that we will have a code freeze at 5 PM today. Jennifer Jennifer Godinez wrote: Just a heads-up that 2D will integrate on 6/30th for b63 . Please plan to put your fixes before the code freeze which is 6/23rd, 5 PM. Thank you. Jennifer

Re: [OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Andrew Haley
Mario Torre wrote: > Hello all! > > I have a problem with a block of code that checks if _LITTLE_ENDIAN is > defined, the code is in little cms and looks like: > > #ifndef _LITTLE_ENDIAN > #define USE_BIG_ENDIAN 1 > #endif > > The issue that I have is that on VxWorks, the target I'm working on

[OpenJDK 2D-Dev] _LITTLE_ENDIAN

2009-06-23 Thread Mario Torre
Hello all! I have a problem with a block of code that checks if _LITTLE_ENDIAN is defined, the code is in little cms and looks like: #ifndef _LITTLE_ENDIAN #define USE_BIG_ENDIAN 1 #endif The issue that I have is that on VxWorks, the target I'm working on, there is always a definition of _

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-06-23 Thread Clemens Eisserer
Hi, > - Accessors can be inlined if they are final, but these aren't.  As it turns > out, SG2D itself is final and so I believe that is enough for them to be > inlined, but I tend to make methods final as well to underscore that they > are intended to be inlined, and also in case we eventually dec