[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6829673: ThinLineTest: A line < 1 pixel disappears.

2009-08-04 Thread jennifer . godinez
Changeset: 7fe0497ee5b5 Author:jgodinez Date: 2009-08-04 17:25 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7fe0497ee5b5 6829673: ThinLineTest: A line < 1 pixel disappears. Reviewed-by: igor, prr Contributed-by: rkennke ! src/share/classes/sun/java2d/pisces/PiscesRenderin

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-08-04 Thread Jim Graham
Roman Kennke wrote: http://cr.openjdk.java.net/~neugens/100068/webrev.06/ So the short story is the webrev.05 was actually better and we better forget about webrev.06 at this point? It also looks like the webrev.05 is better than a stock JDK - even more promising! Regarding webrev.05, I f

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-08-04 Thread Roman Kennke
Hi Mario, > I implemented the method based approach. What I did was to introduce an > interface that all loops implements, this interface consist of a single > method that returns a boolean. > > I made the implementation final everywhere to try to limit the impact of > it, although I'm not sur

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-08-04 Thread Mario Torre
Il 22/07/2009 02:11, Jim Graham ha scritto: It's odd that J2DBench showed a difference since nothing you did should have affected those benchmarks. I don't think it has any benchmark which shows the impact of a pipeline validation, so your standalone test is the only one that I think addresses th