Re: [OpenJDK 2D-Dev] [PATCH] FontManager refactoring, rev6

2009-08-05 Thread Phil Race
Roman, Roman Kennke wrote: Hi there, 6th round of the FontManager refactoring. Can I assume you changed nothing except what you call out here ? In which case I'm fine except for one thing : WPathGraphics.java I see you moved the definition of textLayoutIsCompatible in here. Whilst its use

[OpenJDK 2D-Dev] [PATCH] FontManager refactoring, rev6

2009-08-05 Thread Roman Kennke
Hi there, 6th round of the FontManager refactoring. > you aren't using these import in sun.font.FontManager : >30 import java.util.Locale; >31 import java.util.TreeMap; >32 >33 import javax.swing.plaf.FontUIResource; > > There may be other such cases but its easy to see in this m

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-08-05 Thread Mario Torre
Il 04/08/2009 23:50, Jim Graham ha scritto: Roman Kennke wrote: http://cr.openjdk.java.net/~neugens/100068/webrev.06/ So the short story is the webrev.05 was actually better and we better forget about webrev.06 at this point? It also looks like the webrev.05 is better than a stock JDK - even