Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

2009-09-25 Thread Jim Graham
Sorry, after the flurry of emails here on other topics I just realized this was getting buried. The latest changes look good to me. I just did a "one last grep through the sources" pass and noticed that X11SD and GDIWindowSD also call getRenderLoops. They always call it, though, because they

Re: [OpenJDK 2D-Dev] Review Request for 6879044

2009-09-25 Thread Mandy Chung
There is no change to the log messages emitted from awt/2d/swing. The only impact to the end users is if they enable logging by modifying the system-wide logging.properties (see below); otherwise, the end users will not notice any change due to this fix. The following are the common ways to e

Re: [OpenJDK 2D-Dev] Review Request for 6879044

2009-09-25 Thread Igor Nekrestyanov
We have discussed this with Anthony and Andrei offline and they do not seem to have any blocking concerns. There is one suggestion though - there should be simple explanation for "are there any changes required on the end user side to enable logging and if so, what are they". Logging is mostly

Re: [OpenJDK 2D-Dev] Review Request for 6879044

2009-09-25 Thread Andrei Dmitriev
We've chatted with Igor and I see no concern. Ok from my side. Thanks, Andrei Andrei V. Dmitriev wrote: Igor Nekrestyanov wrote: Let me clarify this as it is does not directly translate into 3x footprint. But savings are not just "size of classes to be loaded". Common "core" classes are al