Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Andrew John Hughes
2009/10/26 Phil Race : > Andrew John Hughes wrote: >> >> 2009/10/26 Phil Race : >> >>> >>> The fix looks fine. I think it should go via the build forest, in the >>> expectation >>> that build is likely to integrate to master before AWT or 2D (which >>> would have been the second choice). >>> >>> >>

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Phil Race
Andrew John Hughes wrote: 2009/10/26 Phil Race : The fix looks fine. I think it should go via the build forest, in the expectation that build is likely to integrate to master before AWT or 2D (which would have been the second choice). Ok, I can push this now or do you still want to?

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Andrew John Hughes
2009/10/26 Phil Race : > The fix looks fine. I think it should go via the build forest, in the > expectation > that build is likely to integrate to master before AWT or 2D (which > would have been the second choice). > Ok, I can push this now or do you still want to? > And its not a proprietary v

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Phil Race
The fix looks fine. I think it should go via the build forest, in the expectation that build is likely to integrate to master before AWT or 2D (which would have been the second choice). And its not a proprietary vs open thing, rather it seemed more efficient to me to do both at once. -phil. An

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Andrew John Hughes
2009/10/26 Phil Race : > Igor is also fixing the closed src .. > > -phil. > Right, well obviously I can't fix the proprietary source code base by definition. I don't think that's an acceptable reason for refusing external contributions. If you want to continue to maintain a proprietary version a

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Igor Nekrestyanov
I think that's ok. I can take Andrew's webrev and apply my changes and then putback to both workspaces. -igor On 10/26/09 1:16 PM, Phil Race wrote: Igor is also fixing the closed src .. -phil. Andrew John Hughes wrote: 2009/10/26 Igor Nekrestyanov : Andrew, i've filed 6895287 for this an

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Phil Race
Igor is also fixing the closed src .. -phil. Andrew John Hughes wrote: 2009/10/26 Igor Nekrestyanov : Andrew, i've filed 6895287 for this and plan to fix it soon. (this will likely a bit faster in terms of "time to get fix into master"). -igor Thanks for filing a bug ID for this.

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Andrew John Hughes
2009/10/26 Igor Nekrestyanov : > Andrew, > > i've filed 6895287 for this and plan to fix it soon. > (this will likely a bit faster in terms of "time to get fix into master"). > > -igor > Thanks for filing a bug ID for this. I'm already working on a webrev for this, so let's not duplicate the work

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Igor Nekrestyanov
Andrew, i've filed 6895287 for this and plan to fix it soon. (this will likely a bit faster in terms of "time to get fix into master"). -igor On 10/26/09 11:19 AM, Andrew John Hughes wrote: 2009/10/26 Kelly O'Hair: Is someone fixing this bootstrap build problem with FontManager.getFontPat

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Andrew John Hughes
2009/10/26 Kelly O'Hair : > > Is someone fixing this bootstrap build problem with > FontManager.getFontPath(true) and the fontchecker? > > Not sure I care much how it gets fixed, I just need it fixed. > > -kto > > You and me both! I'll look at removing fontchecker. -- Andrew :-) Free Java Softw

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Kelly O'Hair
Is someone fixing this bootstrap build problem with FontManager.getFontPath(true) and the fontchecker? Not sure I care much how it gets fixed, I just need it fixed. -kto

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Phil Race
Or we could stop building fontchecker and discard it. It was introduced in the 1.4.2 when we had native code that sometimes crashed the JRE on seeing a bad font file. The windows jre installer used it in 1.4.2 and 1.5. The installer stopped using it in 1.6 (6239557) but we continued to build it

Re: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6795908: Refactor FontManager

2009-10-26 Thread Andrew John Hughes
2009/8/7 : > Changeset: 64b0c953635d > Author:    rkennke > Date:      2009-08-07 18:31 +0200 > URL:       http://hg.openjdk.java.net/jdk7/2d/jdk/rev/64b0c953635d > > 6795908: Refactor FontManager > Reviewed-by: prr, igor > > ! make/sun/awt/FILES_export_windows.gmk > ! make/sun/awt/make.depend > !