Re: [OpenJDK 2D-Dev] Corner case drawing wide lines of zero length

2010-06-16 Thread Denis Lila
Oops, I forgot to attach the patch. - Original Message - From: "Denis Lila" To: "Jon VanAlten" Cc: 2d-dev@openjdk.java.net Sent: Wednesday, June 16, 2010 4:28:27 PM GMT -05:00 US/Canada Eastern Subject: Re: [OpenJDK 2D-Dev] Corner case drawing wide lines of zero length So, I've been loo

Re: [OpenJDK 2D-Dev] Corner case drawing wide lines of zero length

2010-06-16 Thread Denis Lila
So, I've been looking at this a bit more, and I noticed that there was a problem when a non-diagonal affine transformation was in effect. This was because scaledLineWidth2 was being used to draw the end caps, but this variable is valid only when the linear transformation in effect is of the form [[

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] Fix for bug where long dashed lines can make graphics go black.

2010-06-16 Thread Denis Lila
The reproducer is: https://bugzilla.redhat.com/attachment.cgi?id=417597 I have attached a JTreg test version of it. - Original Message - From: "Andrew John Hughes" To: "Denis Lila" Cc: 2d-dev@openjdk.java.net Sent: Wednesday, June 16, 2010 11:18:42 AM GMT -05:00 US/Canada Eastern Subjec

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6961732: FontMetrics.getLeading() may be negative in freetype-based OpenJDK builds.

2010-06-16 Thread neugens . limasoftware
Changeset: 8b55669c7b7a Author:neugens Date: 2010-06-16 20:46 +0200 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/8b55669c7b7a 6961732: FontMetrics.getLeading() may be negative in freetype-based OpenJDK builds. Summary: Fix premature integer roundings to preserve correct height,

Re: [OpenJDK 2D-Dev] Font rendering issue

2010-06-16 Thread Mario Torre
Il giorno mer, 16/06/2010 alle 19.40 +0200, Mario Torre ha scritto: > Il giorno mer, 16/06/2010 alle 18.52 +0200, Mario Torre ha scritto: > > Il giorno mer, 16/06/2010 alle 09.37 -0700, Phil Race ha scritto: > > > 6961732: FontMetrics.getLeading() may be negative in freetype-based > > > OpenJDK bu

Re: [OpenJDK 2D-Dev] Font rendering issue

2010-06-16 Thread Mario Torre
Il giorno mer, 16/06/2010 alle 18.52 +0200, Mario Torre ha scritto: > Il giorno mer, 16/06/2010 alle 09.37 -0700, Phil Race ha scritto: > > 6961732: FontMetrics.getLeading() may be negative in freetype-based > > OpenJDK builds > > > > -phil. > > Hi Phil, I need to fill the reviewer field, what

Re: [OpenJDK 2D-Dev] Font rendering issue

2010-06-16 Thread Mario Torre
Il giorno mer, 16/06/2010 alle 09.37 -0700, Phil Race ha scritto: > 6961732: FontMetrics.getLeading() may be negative in freetype-based > OpenJDK builds > > -phil. > Hi Phil, Thank you, I'm still compiling the j2d forest, then I'll push to the 2d-gate. Thanks, Mario -- pgp key: http://subke

Re: [OpenJDK 2D-Dev] Font rendering issue

2010-06-16 Thread Phil Race
6961732: FontMetrics.getLeading() may be negative in freetype-based OpenJDK builds -phil. On 6/16/2010 8:43 AM, Mario Torre wrote: Il giorno ven, 11/06/2010 alle 09.51 +0200, Mario Torre ha scritto: Il giorno gio, 10/06/2010 alle 14.28 -0700, Phil Race ha scritto: I've root-caused

Re: [OpenJDK 2D-Dev] Font rendering issue

2010-06-16 Thread Mario Torre
Il giorno ven, 11/06/2010 alle 09.51 +0200, Mario Torre ha scritto: > Il giorno gio, 10/06/2010 alle 14.28 -0700, Phil Race ha scritto: > > I've root-caused this although its still not clear what's the ideal answer, > > the simplest and safest may be Mario's proposed fix here from 5/5/2010 : I've

[OpenJDK 2D-Dev] [PATCH FOR REVIEW] Fix for bug where long dashed lines can make graphics go black.

2010-06-16 Thread Andrew John Hughes
On 9 June 2010 23:49, Denis Lila wrote: > Hello. > > I think I have a fix for this bug: > https://bugzilla.redhat.com/show_bug.cgi?id=597227 > > The bug was caused by a few integer overflows in sun/java2d/pisces/Dasher.java > and sun/java2d/pisces/Stroker.java which would cause the whole container