Re: [OpenJDK 2D-Dev] Various fixes to pisces stroke widening code

2010-07-13 Thread Jim Graham
Hi Denis, float operations are pretty fast and they are usually done in a separate part of the processor so the compiler can schedule a lot of bookkeeping instructions to run in parallel with waiting for the results of the FP instruction. In the end, they often end up being free if there are

Re: [OpenJDK 2D-Dev] Various fixes to pisces stroke widening code

2010-07-13 Thread Denis Lila
Hello. And, I just finished it. At least it compiled successfully. I'm sure there are a few runtime bugs. I'll try to have a webrev out by today. Regards, Denis. - Jim Graham james.gra...@oracle.com wrote: Hi Denis, float operations are pretty fast and they are usually done in a

Re: [OpenJDK 2D-Dev] Fix for drawing round endcaps on scaled lines.

2010-07-13 Thread Jim Graham
Hi Denis, In looking through this code, I can see where it emits the proper join for ccw turns, but it looks like it just emits a round join for cw turns. Is that true? Doesn't this mean that a cw path will always have round joins? Or am I missing something? My expectation was that the

Re: [OpenJDK 2D-Dev] Fix for drawing round endcaps on scaled lines.

2010-07-13 Thread Jim Graham
Sorry, ignore this message. I was misinterpreting the field internalJoins to mean joins on the inside of the path (!ccw). It actually means implicit joins in the middle of a flattened curve and I can see why those are always done round, so the code makes sense now (naming of the variable