Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-12-14 Thread Jim Graham
Hi Denis, That sounds like some very good ideas for making this method very accurate. On the other hand, we're starting to get into the territory where an advanced math package should be catering to these requirements. The solveCubic was an internal helper function for implementing the hit t

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-12-14 Thread Denis Lila
Hi Jim. > How big are these errors expressed as multiples of the ULP of the > coefficients? Obviously 1e-17 is a lot smaller than 1e-4, but was > 1e-17 > representing "just a couple of bits of error" or was it still way off > with respect to the numbers being used? And were these fairly obscure

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-12-14 Thread Jim Graham
Hi Denis, On 12/14/2010 5:11 PM, Denis Lila wrote: I have one question though: how fast does this have to be? I can come up with fairly reasonable examples for which both CubicCurve2D.solveCubic and the implementation I found give very inaccurate results The existing method was not very accura

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-12-14 Thread Denis Lila
Hi Jim. > You might want to submit it as a separate push and get credit for > fixing 4645692 (solveCubic doesn't return all answers), Sure, that sounds good. Reading through the code I found, I spotted a few things that might have been problematic in some extremely rare cases. I've been working o

[OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6766342: Improve performance of Ductus rasterizer

2010-12-14 Thread james . graham
Changeset: 4d6f9aaa2600 Author:flar Date: 2010-12-14 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/4d6f9aaa2600 6766342: Improve performance of Ductus rasterizer Reviewed-by: jgodinez, prr ! make/sun/awt/make.depend ! make/sun/awt/mapfile-vers ! make/sun/awt/mapfile-v

[OpenJDK 2D-Dev] Webrevs for AA transformed rectangles and wide lines

2010-12-14 Thread Jim Graham
This is a forward port of the second half of the fixes in 6u12 for doing fast transformed rectangles and wide lines. This time the AA pipelines are upgraded to handle parallelograms directly and some new native loops are added to do direct rasterization of AA parallelogram filling and stroking

Re: [OpenJDK 2D-Dev] Reviewer needed - new regression tests which check 2D renderer behaviour

2010-12-14 Thread Anthony Petrov
Hi Pavel, I think these are 2D tests. I'm copying 2d-dev@, and BCC'ing awt-...@. -- best regards, Anthony On 12/14/2010 5:27 PM, Pavel Tisnovsky wrote: Hi all, I'd like to add five new regression tests which check 2D renderer behaviour. Corrections checked by these tests were already pushed b

Re: [OpenJDK 2D-Dev] Reviewer needed - new regression tests which check 2D renderer behaviour

2010-12-14 Thread Denis Lila
Hello. Please don't review these yet. I'm making some modifications to make them much more robust. We should have a new version of the tests in maybe one hour (at most). Regards, Denis.