Re: [OpenJDK 2D-Dev] OpenJDK Warning hackathon :) - patch 1

2011-11-30 Thread Roman Kennke
> Btw, on the other mailing lists they are also discussing about the warnings > day, so I guess I'm not so early ;) Congratulations, it's probably the first time in your life that you're early ;-) Seriously, maybe this comes from the fact that today started 9 hours earlier in central Europe than

Re: [OpenJDK 2D-Dev] OpenJDK Warning hackathon :) - patch 1

2011-11-30 Thread Mario Torre
Il giorno 30/nov/2011, alle ore 21:04, Phil Race ha scritto: > Is this a default javac warning or just from the lint option ? > Any way, fair enough, fix looks fine, although you seem to be getting an > early start on warnings day. > I think its right to handle these on the 2D list as that's the

[OpenJDK 2D-Dev] hg: jdk8/2d/hotspot: 42 new changesets

2011-11-30 Thread lana . steuck
Changeset: 869804b759e7 Author:jcoomes Date: 2011-11-04 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/869804b759e7 7108553: Bump the hs23 build number to 06 Reviewed-by: johnc Contributed-by: alejandro.muri...@oracle.com ! make/hotspot_version Changeset: 5bda8dae

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 34 new changesets

2011-11-30 Thread lana . steuck
Changeset: 2a147f854257 Author:twisti Date: 2011-11-02 02:03 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2a147f854257 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods Reviewed-by: jrose, never ! src/share/classes/java/lang/invo

[OpenJDK 2D-Dev] hg: jdk8/2d/langtools: 6 new changesets

2011-11-30 Thread lana . steuck
Changeset: 36553cb94345 Author:jjg Date: 2011-11-08 17:06 -0800 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/36553cb94345 7108668: allow Log to be initialized and used earlier Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/

[OpenJDK 2D-Dev] hg: jdk8/2d/corba: 2 new changesets

2011-11-30 Thread lana . steuck
Changeset: 44c269731425 Author:coffeys Date: 2011-11-11 10:16 + URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/44c269731425 7091388: Regular unexplained npe's from corba libs after system has been running for days Reviewed-by: alanb ! src/share/classes/com/sun/corba/se/impl

Re: [OpenJDK 2D-Dev] OpenJDK Warning hackathon :) - patch 1

2011-11-30 Thread Phil Race
Is this a default javac warning or just from the lint option ? Any way, fair enough, fix looks fine, although you seem to be getting an early start on warnings day. I think its right to handle these on the 2D list as that's the right place to ask for a review -- and to push into the 2D forest.

Re: [OpenJDK 2D-Dev] OpenJDK Warning hackathon :) - patch 1

2011-11-30 Thread David Gilbert
http://java.sun.com/docs/codeconv/CodeConventions.pdf Section 10.2 Best regards, David Gilbert http://www.jfree.org/ On 30/11/2011 20:21, Phil Race wrote: Mario, What is the warning that this fixes ? What is the reasoning ? I'm supposing referencing a class constant via an instance is somehow

Re: [OpenJDK 2D-Dev] OpenJDK Warning hackathon :) - patch 1

2011-11-30 Thread Mario Torre
Il giorno 30/nov/2011, alle ore 20:21, Phil Race ha scritto: > Mario, > > What is the warning that this fixes ? What is the reasoning ? > I'm supposing referencing a class constant via an instance is > somehow considered bad form but who made that call ? > > -phil. > > On 11/30/2011 10:57 AM, Ma

Re: [OpenJDK 2D-Dev] OpenJDK Warning hackathon :) - patch 1

2011-11-30 Thread Phil Race
Mario, What is the warning that this fixes ? What is the reasoning ? I'm supposing referencing a class constant via an instance is somehow considered bad form but who made that call ? -phil. On 11/30/2011 10:57 AM, Mario Torre wrote: This is the patch against the main jdk8 forest repository:

[OpenJDK 2D-Dev] OpenJDK Warning hackathon :) - patch 1

2011-11-30 Thread Mario Torre
This is the patch against the main jdk8 forest repository: http://cr.openjdk.java.net/~neugens/warning-hackaton/webrev.02/ Btw, there is also an unused import which doesn't really issues a warning but I thought to clean it as well. Cheers, Mario -- pgp key: http://subkeys.pgp.net/ PGP Key ID: 8