Re: [OpenJDK 2D-Dev] Request for review: 7151427: Potential memory leak in error handling code in X11SurfaceData.c

2012-03-11 Thread Sean Chou
Thanks to Andrew, Phil, and Jennifer ! And thanks to Charles for committing. On Fri, Mar 9, 2012 at 11:43 PM, Andrew Brygin wrote: > Hello Sean, > > I have reviewed the change and it looks fine to me. > > Thanks, > Andrew > > > On 07.03.2012 11:31, Sean Chou wrote: > > Hi all, > > I still

Re: [OpenJDK 2D-Dev] Request for review: 7151427: Potential memory leak in error handling code in X11SurfaceData.c

2012-03-11 Thread Charles Lee
Hi Sean, The patch has been committed. Please check and verify: Changeset: b1af41b86f9f Author:littlee Date: 2012-03-12 13:30 +0800 URL:http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b1af41b86f9f 7151427: Fix the potential memory leak in error handling code in X11SurfaceData.c Summary: Fr

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 7151427: Fix the potential memory leak in error handling code in X11SurfaceData.c

2012-03-11 Thread littlee
Changeset: b1af41b86f9f Author:littlee Date: 2012-03-12 13:30 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b1af41b86f9f 7151427: Fix the potential memory leak in error handling code in X11SurfaceData.c Summary: Free the memory in the error handling code. Reviewed-by: prr,

Re: [OpenJDK 2D-Dev] Remove including of link.h to improve portability

2012-03-11 Thread Jonathan Lu
Bug 7152519 has been created for this patch. - Jonathan On 03/09/2012 07:49 PM, Jonathan Lu wrote: Hello 2d-dev, I find that link.h is included in several place of OpenJDK code, mostly together with dlfcn.h, but this caused portability problem in my testing on some Unix platforms, such as AI