Hi Clemens,
Looks fine should solve the problem. Perhaps it would have been nice to
calculate the interpolation with the clip but then you'd need to pay
attention to whether it was a complex clip or a simple rectangular one
and it may be better to do the delegation that you are doing now ...
-ph
Changeset: a8773780c583
Author:prr
Date: 2012-04-05 15:17 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a8773780c583
7159136: JDK 7 font manager refactoring left JNI header generation and
inclusion out of sync
Reviewed-by: igor, jgodinez
! make/sun/font/Makefile
! make/sun
Changeset: 9383a3749940
Author:prr
Date: 2012-04-05 15:14 -0700
URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9383a3749940
7159041: Fix for 7152519 causing build breakage.
Reviewed-by: igor, jgodinez
! src/solaris/native/sun/java2d/opengl/OGLFuncs_md.h
Hi Mario,
> The patch looks good to me.
Thanks for taking a look.
> Just wondering what is the impact of those two checks:
>
> + if (compClip.contains(transX1, transY1)
> + && compClip.contains(transX2, transY2)) {
>
> for the most common cases?
I wasn't able to measure any
Hi Clemens,
The patch looks good to me.
Just wondering what is the impact of those two checks:
+if (compClip.contains(transX1, transY1)
+&& compClip.contains(transX2, transY2)) {
for the most common cases?
Cheers,
Mario
2012/4/5 Clemens Eisserer :
> Hi,
>
> Please take
Hi,
Please take a look at the patch for bug 7150134, located at
http://cr.openjdk.java.net/~ceisserer/7150134/
The problem was caused by a fast-path in drawLine() which didn't take
clipping into account, therefor huge lines that would have been
clipped away caused OOMs in xrender's bresenham code
