Looks ok to me.
-igor
On 9/4/12 8:27 AM, Scott Kovatch wrote:
(resending, now that I'm on 2d-dev.)
I posted a new webrev at http://cr.openjdk.java.net/~skovatch/7187834/webrev.01/
In ImageSurfaceData, it looks like we are trying to get back to a pure CTM
(i.e., no transform of any kind applie
I need one more reviewer/+1... anyone?
-- Scott K.
Begin forwarded message:
> From: Scott Kovatch
> Subject: Re: Review: Remove private API from graphics code
> Date: September 4, 2012 8:16:03 AM PDT
> To: Phil Race
> Cc: "awt-...@openjdk.java.net" , 2d-dev
> <2d-dev@openjdk.java.net>, "macos
On 9/4/12 21:45, Phil Race wrote:
On 9/4/2012 10:27 AM, Alexander Zuev wrote:
Phil,
On 9/4/12 21:05, Phil Race wrote:
Alexander,
This is a shared code change. Did you test it on Windows ?
Not yet - i'm building Windows version of jdk8 with that fix right
now and will test it tomorrow
but i d
On 9/4/2012 10:27 AM, Alexander Zuev wrote:
Phil,
On 9/4/12 21:05, Phil Race wrote:
Alexander,
This is a shared code change. Did you test it on Windows ?
Not yet - i'm building Windows version of jdk8 with that fix right now
and will test it tomorrow
but i don't see how changing of the sequen
Phil,
On 9/4/12 21:05, Phil Race wrote:
Alexander,
This is a shared code change. Did you test it on Windows ?
Not yet - i'm building Windows version of jdk8 with that fix right now
and will test it tomorrow
but i don't see how changing of the sequence of invalidation of
accelerated texture an
Alexander,
This is a shared code change. Did you test it on Windows ?
In fact, can you explain why this has not been seen on Windows
in the many years now that we've had this code ? eg, did we
recently introduce a regression, is this MacOS specific ?
-phil.
On 9/4/2012 9:18 AM, Alexander Zuev w
Approved.
-phil.
On 9/4/2012 8:27 AM, Scott Kovatch wrote:
(resending, now that I'm on 2d-dev.)
I posted a new webrev at http://cr.openjdk.java.net/~skovatch/7187834/webrev.01/
In ImageSurfaceData, it looks like we are trying to get back to a pure CTM
(i.e., no transform of any kind applied.)
Hello,
please review my fix for CR 7175183: [macosx] Objective-C exception
thrown when switching monitor configuration
The NPE happens because of the getBackupSurface method call may
result in the resetting of the current accelerated surface to null. The
idea of the fix is to move the in
I posted a new webrev at http://cr.openjdk.java.net/~skovatch/7187834/webrev.01/
In ImageSurfaceData, it looks like we are trying to get back to a pure CTM
(i.e., no transform of any kind applied.) before we draw the image. We have
already saved the state, but saving the state doesn't reset it.
(resending, now that I'm on 2d-dev.)
I posted a new webrev at http://cr.openjdk.java.net/~skovatch/7187834/webrev.01/
In ImageSurfaceData, it looks like we are trying to get back to a pure CTM
(i.e., no transform of any kind applied.) before we draw the image. We have
already saved the state, b
10 matches
Mail list logo
