Re: [OpenJDK 2D-Dev] [8] Review request for CR 7145406 - [macosx] Migrate Apple tests from macosx-port to 7u

2013-03-11 Thread Konstantin Shefov
Phil, 12.03.2013 0:22, Phil Race wrote: On 3/11/2013 1:07 PM, Konstantin Shefov wrote: All these tests compile and run under all OSs, not MacOS only. I find that very difficult to believe. \re\jdk\8\promoted\latest\binaries\windows-i586\bin\javac APIPresent.java APIPresent.java:31: error: pa

Re: [OpenJDK 2D-Dev] [8] Review request for CR 7145406 - [macosx] Migrate Apple tests from macosx-port to 7u

2013-03-11 Thread Alan Bateman
Konstantin, Can you hold off pushing these tests until there has been wider review? I may be mistaken but I think that many of these tests (at least for the non-client areas) were deliberately not pushed to jdk7u and jdk8 when bringing the port in. From what I can remember there was overlap wi

Re: [OpenJDK 2D-Dev] [8] Review request for CR 7145406 - [macosx] Migrate Apple tests from macosx-port to 7u

2013-03-11 Thread Phil Race
Konstantin, On 3/11/2013 1:45 PM, Konstantin Shefov wrote: Phil, 12.03.2013 0:22, Phil Race wrote: On 3/11/2013 1:07 PM, Konstantin Shefov wrote: All these tests compile and run under all OSs, not MacOS only. I find that very difficult to believe. \re\jdk\8\promoted\latest\binaries\windows

Re: [OpenJDK 2D-Dev] [8] Review request for CR 7145406 - [macosx] Migrate Apple tests from macosx-port to 7u

2013-03-11 Thread Konstantin Shefov
All these tests compile and run under all OSs, not MacOS only. There are a lot of awt and swing tests that depend on test.java.awt.regtesthelpers, they are in the openjdk repo. Almost none of regression tests are ever run without JTREG. Konstantin 11.03.2013 23:53, Phil Race пишет: Konstantin

Re: [OpenJDK 2D-Dev] [8] Review request for CR 7145406 - [macosx] Migrate Apple tests from macosx-port to 7u

2013-03-11 Thread Phil Race
On 3/11/2013 1:07 PM, Konstantin Shefov wrote: All these tests compile and run under all OSs, not MacOS only. I find that very difficult to believe. \re\jdk\8\promoted\latest\binaries\windows-i586\bin\javac APIPresent.java APIPresent.java:31: error: package com.apple.eio does not exist import

Re: [OpenJDK 2D-Dev] [7u-dev] Request for review for CR 8007748 - MacOSX build error : cast of type 'SEL' to 'uintptr_t' (aka 'unsigned long') is deprecated; use sel_getName instead

2013-03-11 Thread Dalibor Topic
Thanks - pushed into jdk7u-dev: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/f371d9a1496f cheers, dalibor topic On 3/11/13 1:15 PM, Anthony Petrov wrote: > Looks fine to me. Thanks for back-porting this fix. > > -- > best regards, > Anthony > > On 03/08/13 14:05, Dalibor Topic wrote: >>

Re: [OpenJDK 2D-Dev] [7u-dev] Request for review for CR 8007748 - MacOSX build error : cast of type 'SEL' to 'uintptr_t' (aka 'unsigned long') is deprecated; use sel_getName instead

2013-03-11 Thread Anthony Petrov
Looks fine to me. Thanks for back-porting this fix. -- best regards, Anthony On 03/08/13 14:05, Dalibor Topic wrote: Bug: http://bugs.sun.com/view_bug.do?bug_id=8007748 JDK 8 changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5f0217537435 - the changeset applies with no changes to jdk7u-d

[OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-03-11 Thread Anton Litvinov
Hello, Please review the following fix. This is the second reminder message. Please take into account that the original review request was sent more than 1 month ago and no response has been received yet. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007642 Webrev: http://cr.openjd

Re: [OpenJDK 2D-Dev] [8] Review request for 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux

2013-03-11 Thread Anton Litvinov
Hello, Please review the following fix for a bug. The fix passed 3 cycles of review by AWT development team. Artem Ananiev and Anthony Petrov approved it. But because the fix modifies also Java 2D Graphics code, review by 2D Graphics development team is necessary. Bug: http://bugs.sun.com/bu