Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 [macosx] Text (Label) in a JTabbedPane is incorrectly drawn

2013-05-21 Thread Sergey Bylokhov
Hi, Phil. Looks like there is workaround for this and now it should be removed. I'll take a look at it. On 22.05.2013 3:47, Phil Race wrote: Sergey, This needs another look. Although it fixed some clearly broken cases, there is a rotated tab pane label option in SwingSet2, and it turns out t

Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 [macosx] Text (Label) in a JTabbedPane is incorrectly drawn

2013-05-21 Thread Phil Race
Sergey, This needs another look. Although it fixed some clearly broken cases, there is a rotated tab pane label option in SwingSet2, and it turns out that at least for me that was working *before* the fix and now its broken. So I suppose that there are 2 pieces of code interpreting the sign of t

Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 [macosx] Text (Label) in a JTabbedPane is incorrectly drawn

2013-05-21 Thread Phil Race
I think this fix is fine. In the other rasteriser cases we use (T2K, freetype) we also flip the sign of the y advance as it is stored as the image y advance. It looks like this was just missing here. This change should then only affect the final glyph rendering. -phil. On 5/21/2013 12:40 PM, Se

[OpenJDK 2D-Dev] [8] Request for review: 7190349 [macosx] Text (Label) in a JTabbedPane is incorrectly drawn

2013-05-21 Thread Sergey Bylokhov
Hello, Please review the fix for jdk 8. On OSX advanceY in the glyphInfo is inverted. It is used to increment position when the glyph is drawn as part of a string of text: @see DrawGlyphList.c.setupBlitVector(): for (g=0; gglyphs[g].y, y + ginfo->topLeftY); . y +

Re: [OpenJDK 2D-Dev] Defect 7032904(XRender: Java2Demo) remains

2013-05-21 Thread Clemens Eisserer
Hi Andrew, Thanks for your feedback. > Do you know which versions of libXrender are supported? We can check the > version > at configure time: > > $ pkg-config --modversion renderproto > 0.11.1 > > and disable the extension at compile-time. This is especially true with 6 > where, > IIRC, it's

Re: [OpenJDK 2D-Dev] Defect 7032904(XRender: Java2Demo) remains

2013-05-21 Thread Andrew Hughes
- Original Message - > Hi Frank, > > > Recently our team discovered defect 7032904(XRender: Java2Demo : Infinite > > loop in Java_sun_java2d_loops_MaskBlit_MaskBlit on OEL 5.6 x64) still > > exists > > in latest JDK (7u21) on SLES10SP4. It can be easily reproduced by running > > SwingSe