[OpenJDK 2D-Dev] pls review jdk 7 fix for 8015334

2013-06-18 Thread Phil Race
Steven & Andrew, I believe 8015334 : Memory leak in Kerning should be ported to 7u40. Please sanity check this fix which is the same as the already pushed JDK 8 fix : http://cr.openjdk.java.net/~prr/8015334.jdk7/ then I'll see if it'll get accepted into the 7u40 stabilisation forest. -phil.

Re: [OpenJDK 2D-Dev] RFR 6870661 : Setting a custom PrintService on a PrinterJob leads to a PrinterException

2013-06-18 Thread Phil Race
Yes, the driverDoes* fields should be reset, even though I am not sure we need them any more because I think that ever since XP drivers always do their own collation. But some of this code was written when win9x/win nt was supported. @run main/manual=yesno Can be used to write a manual test for

Re: [OpenJDK 2D-Dev] RFR 6870661 : Setting a custom PrintService on a PrinterJob leads to a PrinterException

2013-06-18 Thread Patrick Reinhart
Hi Phil, I will do the suggested changes and check the dialog and enhance my test accordingly. Do you think that the fields driverDoesMultipleCopies and driverDoesCollation should be reset on setPrintService() as follows, because the actual native settings will be obsolete in that case anywa