Re: [OpenJDK 2D-Dev] Request for review: JDK-6870661 Setting a custom PrintService on a PrinterJob leads to a PrinterException

2013-09-16 Thread Patrick Reinhart
Hi Phil, Thanks for the quick response, seems I need some more practice in English ;-) Cheers Patrick Am 16.09.13 18:59, schrieb Phil Race: It looks OK to me although the test has typoes. Marings => Margins Appearence -> Appearance Jennifer : can you review too - then test and commit - wit

[OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-16 Thread Volker Simonis
Resending this to more lists as requested by Alan Bateman with the kind request to anybody to review the parts for which he feels responsible:) For those not up to date, this change is part of the ongoing PowerPC/AIX Porting Project: http://openjdk.java.net/projects/ppc-aix-port https://wiki.openj

Re: [OpenJDK 2D-Dev] Review request for http://cr.openjdk.java.net/~ceisserer/fix10/

2013-09-16 Thread Phil Race
Hi Clemens, I created 8024895: xrender MaskImage cache isn't accounting for change in alpha the webrev and test need a little clean-up : adding the @test and @bug tag + GPL There's a minor formatting error here :- int currentEA =xrMgr.getAlphaColor().getAlpha(); .. missing space after "="

Re: [OpenJDK 2D-Dev] Request for review: JDK-6870661 Setting a custom PrintService on a PrinterJob leads to a PrinterException

2013-09-16 Thread Phil Race
It looks OK to me although the test has typoes. Marings => Margins Appearence -> Appearance Jennifer : can you review too - then test and commit - with typoes fixed. -phil. On 9/15/2013 2:43 AM, Patrick Reinhart wrote: Hi, I need a sponsor and reviewer for my fix at http://reinharts.dyndns.