Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033624: Fix raw and unchecked lint warnings in sun.font

2014-02-05 Thread Alan Bateman
On 05/02/2014 07:41, Joe Darcy wrote: Hello, Please review this change which resolves ~200 raw and unchecked warnings in sun.font. (Afterward, the code is also free the of the cast warning.) JDK-8033624 : Fix raw and unchecked lint warnings in sun.font

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2014-02-05 Thread Anton V. Tarasov
Thanks for the review, Anthony! Regards, Anton. On 04.02.2014 22:55, Anthony Petrov wrote: Hi Anton, I skimmed through the code that I'm familiar with, and the changes look good to me. Someone from Swing and 2D should review their parts, too. -- best regards, Anthony On 2/3/2014 6:36 PM,

Re: [OpenJDK 2D-Dev] [PATCH] Re: JDK-8012351

2014-02-05 Thread Phil Race
So that patch wasn't the right thing but as a result of off-list discussion its become clearer how the problem might occur I've updated https://bugs.openjdk.java.net/browse/JDK-8012351 with the evaluation. And I think this is the right fix for it: http://cr.openjdk.java.net/~prr/8012351/

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033624: Fix raw and unchecked lint warnings in sun.font

2014-02-05 Thread Phil Race
Joe, This help is very much appreciated but can you please re-generate your webrev against jdk9/client and I'll review it then. If this is a problem for you then instead I can take your final patch and commit into the client forest on your behalf. Let me know which you prefer. -phil. On

Re: [OpenJDK 2D-Dev] JDK 9: RFR: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio

2014-02-05 Thread Joe Darcy
Hi Henry, On 02/05/2014 12:19 PM, Henry Jen wrote: Hi, Please review the webrev to clean up raw and unchecked warnings in com.sun.imageio packag at, http://cr.openjdk.java.net/~henryjen/jdk9/8033716/0/webrev/ The more significant change in this webrev is that I have changed the clone()