On 02/19/2014 01:46 PM, Phil Race wrote:
.
http://cr.openjdk.java.net/~henryjen/jdk9/8033716/1/webrev/src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java.sdiff.html
230 public Iterator getImageTypes(int
imageIndex) throws IIOException {
Nitpicky perhaps, but this looks > 80 c
http://cr.openjdk.java.net/~henryjen/jdk9/8033716/1/webrev/src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java.sdiff.html
230 public Iterator getImageTypes(int imageIndex)
throws IIOException {
Nitpicky perhaps, but this looks > 80 chars. If so please split it.
-
W.r.t
ImageIO.java
515 public Iterator iter;
829 public Iterator iter;
I can't see why these are public. I think they should be private
Since you are touching these lines anyway public->private
I was on the look out for changes to public interfaces but I
didn't see any so that's Ok
