Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-02-21 Thread Magnus Ihse Bursie
On 2014-02-20 23:40, Omair Majid wrote: Hi, The following is a preliminary webrev that allows OpenJDK to build and run against a system-installed copy of lcms2 rather than the copy bundled with OpenJDK: root: http://cr.openjdk.java.net/~omajid/webrevs/system-lcms/00/ jdk:

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-02-21 Thread Omair Majid
* Magnus Ihse Bursie magnus.ihse.bur...@oracle.com [2014-02-21 08:21]: On 2014-02-20 23:40, Omair Majid wrote: 1. The sources for the bundled library are contained next to OpenJDK-specific sources. This is not true for the bundled copies of zlib, libpng and giflib. On the other hand, the jpeg

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-02-21 Thread Omair Majid
* Andrew Hughes gnu.and...@redhat.com [2014-02-21 10:36]: I think the j2 convention is reasonable. This is where we disagree. I may have agreed if this was new, but we've been using libjavalcms.so for the lifetime of 7 and I see no reason to change this. Also, j2 seems pretty meaningless.

Re: [OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

2014-02-21 Thread Andrew Hughes
- Original Message - On 2014-02-20 23:40, Omair Majid wrote: Hi, The following is a preliminary webrev that allows OpenJDK to build and run against a system-installed copy of lcms2 rather than the copy bundled with OpenJDK: root:

Re: [OpenJDK 2D-Dev] JDK9: RFR: 8035487: Fix raw and unchecked lint warnings in javax.imageio.spi

2014-02-21 Thread Joe Darcy
On 02/20/2014 10:01 PM, Henry Jen wrote: Hi, Please review the webrev to clean up raw and unchecked warnings in javax.imageio.spi packag at, http://cr.openjdk.java.net/~henryjen/jdk9/8035487/0/webrev/ Cheers, Henry Hi Henry, From a quick look, I didn`t see anything amiss with your

Re: [OpenJDK 2D-Dev] JDK9: RFR: 8035487: Fix raw and unchecked lint warnings in javax.imageio.spi

2014-02-21 Thread Phil Race
Approved. -phil. On 2/20/2014 10:01 PM, Henry Jen wrote: Hi, Please review the webrev to clean up raw and unchecked warnings in javax.imageio.spi packag at, http://cr.openjdk.java.net/~henryjen/jdk9/8035487/0/webrev/ Cheers, Henry

Re: [OpenJDK 2D-Dev] JDK 9: RFR[2]: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio

2014-02-21 Thread Phil Race
Ditto . -phil. On 2/20/2014 11:48 PM, Andrew Brygin wrote: Hello Henry, the fix looks fine to me. Thanks, Andrew On 2/21/2014 1:01 AM, Henry Jen wrote: Hi, Please review the latest update, I think this should address the issues raised,

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2014-02-21 Thread Jim Graham
Hi Alexandr, On 2/18/14 7:33 AM, Alexander Scherbatiy wrote: Hi Jim, Let's divide the discussion into two part. 1. Where it is better to hold resolution variants? Putting resolution variants in Image class brings some questions like: - Some type of images do not need to have