Hi Anton,
A lot of those tests seem out of whack in that they test related
conditions, but not the exact condition itself. What we really want is
for every index of the form:
offset + y * scanlineStride + x + {0 -> numcomponents-1} => [0,
buf.length-1]
to be in the array for all valid x,y
Hi Phil,
Since the fix for JDK-8031625 has been pushed, we have no more blockers
for the doclint fix.
Could you please review this webrev:
http://cr.openjdk.java.net/~cl/8032527/webrev.01/
Thanks,
Sonali
On 3/18/2014 1:48 PM, Phil Race wrote:
A late update ..
The javadoc change is
8031625:
Below are some thoughts about TK.createMRImage(...) method
On 3/24/2014 4:52 PM, Alexander Scherbatiy wrote:
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8029339/webrev.03/
- baseImageWidth/Height arguments are added to the
getResolutionVariant(...) metho
Looks good to me.
/Magnus
> On 27 mar 2014, at 12:47, Erik Joelsson wrote:
>
> Further testing revealed some more issues. New webrev:
>
> http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/
>
> I had to break out the devkit/sysroot parts from from BASIC_SETUP_PATHS so
> that it happen
Further testing revealed some more issues. New webrev:
http://cr.openjdk.java.net/~erikj/8038340/webrev.root.03/
I had to break out the devkit/sysroot parts from from BASIC_SETUP_PATHS
so that it happened after the early custom hook.
/Erik
On 2014-03-26 12:36, Magnus Ihse Bursie wrote:
On
Yes, basically. And, optionally, an extra path (for non-toolchain binaries). So
setting --with-devkit is, in a way, a convenient way of setting all these three
options, in a way that works together and makes sense.
That is, more or less, the same behavior we've had all the time, but it's
slight
