Re: [OpenJDK 2D-Dev] JDK9: RFR: 8039342: Fix raw and unchecked warnings in sun.awt.*

2014-04-25 Thread Henry Jen
Thanks for the reviw. On 04/23/2014 02:37 PM, Jim Graham wrote: Shouldn't Order2, lines 50,77 be ""? Ditto for Order3, lines 56,108? I don't think we ever use these methods with any other type of Vector, but I guess I can see that the choice you made might be a more general choice. Right, I

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2014-04-25 Thread Alexander Scherbatiy
On 4/25/2014 2:17 AM, Jim Graham wrote: Hi Alexandr, I asked for who was requesting these facilities and you responded with the solution you are planning to provide. I don't care what the solution looks like if we have nobody asking for the feature - I am asking who is asking for these capab

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface->sw blit is extremely slow

2014-04-25 Thread Andrew Brygin
On 4/25/2014 4:52 PM, Sergey Bylokhov wrote: On 4/25/14 4:35 PM, Andrew Brygin wrote: Hello Sergey, the fix looks fine to me. The tests do not force the OGL pipeline, so they will verify the change only on macosx. Is it done for purpose? Yes, I assume that the jdk know better, when to use

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface->sw blit is extremely slow

2014-04-25 Thread Sergey Bylokhov
On 4/25/14 4:35 PM, Andrew Brygin wrote: Hello Sergey, the fix looks fine to me. The tests do not force the OGL pipeline, so they will verify the change only on macosx. Is it done for purpose? Yes, I assume that the jdk know better, when to use ogl pipeline, and if it was not used by defa

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface->sw blit is extremely slow

2014-04-25 Thread Andrew Brygin
Hello Sergey, the fix looks fine to me. The tests do not force the OGL pipeline, so they will verify the change only on macosx. Is it done for purpose? Thanks, Andrew On 4/24/2014 10:43 PM, Sergey Bylokhov wrote: Hi, Jim. Yes, we shouldn't depend on default values of SKIP_** The new vers