Hi Sergey,
I think the bug is in the readObject routine. It sets the initial size
of the arrays based on if the number of segments/coords is "< 0" and it
sets them to INIT_SIZE or INIT_SIZE*2 accordingly. Those tests should
be "< INIT_SIZE(*2)"...
...jim
On 4/30/14
Trying again with awt as "To:" rather than bcc: ..
-phil.
On 4/30/2014 2:12 PM, Phil Race wrote:
Looks OK to me, but adding awt-dev as splashscreen is owned by AWT.
-phil.
On 4/30/2014 1:48 PM, Omair Majid wrote:
Hi,
As indicated in the libjpeg API documentation [1], the standard libjpeg
he
Looks OK to me, but adding awt-dev as splashscreen is owned by AWT.
-phil.
On 4/30/2014 1:48 PM, Omair Majid wrote:
Hi,
As indicated in the libjpeg API documentation [1], the standard libjpeg
headers are: jpeglib.h, jerror.h, jconfig.h, jmorecfg.h.
splashscreen_jpeg.c violates this layering a
Hi,
As indicated in the libjpeg API documentation [1], the standard libjpeg
headers are: jpeglib.h, jerror.h, jconfig.h, jmorecfg.h.
splashscreen_jpeg.c violates this layering and uses the SIZEOF macro
from the non-public header jinclude.h directly. This macro is a wrapper
over sizeof. The code i
* Phil Race [2014-04-30 15:22]:
> On 4/30/2014 11:52 AM, Omair Majid wrote:
> >
> >In another thread, it was pointed out that j2 stands for "Java to". As
> >in "Java to lcms".
> Really ? That is not something that was obvious to me ..
I don't think it's obvious to anyone :)
I found out about it
On 4/30/2014 11:52 AM, Omair Majid wrote:
In another thread, it was pointed out that j2 stands for "Java to". As
in "Java to lcms".
Really ? That is not something that was obvious to me ..
Presumably libjavajpeg.so would also be just the 'stub' code that via JNI
interfaces to the exported int
* Phil Race [2014-04-30 14:33]:
> The "j2" idea presumably comes from "Java 2" which was a marketing invention
> for JDK 1.2 in 1998 and has since been purged from all our docs,
> file names etc etc ..
> so it would not be my choice. Consider it obsolete / deprecated ..
In another thread, it was
The "j2" idea presumably comes from "Java 2" which was a marketing invention
for JDK 1.2 in 1998 and has since been purged from all our docs, file
names etc etc ..
so it would not be my choice. Consider it obsolete / deprecated ..
So libjavajpeg.so would be better.
Presumably libjavajpeg.so w
Hello.
Please review the fix for jdk 9.
needRoom() method does not take into account that current array of types
can be empty. In this case it fails to increase it.
I handle this case and increase the size of the array by 1 instead of
INIT_SIZE, because I assume that the user intentionally try t
- Original Message -
> Hi,
>
> After updating OpenJDK so that system versions of the giflib, libpng and
> lcms2 libraries can be used by OpenJDK, I am looking at addressing
> libjpeg next.
>
> The trouble here is that there is an actual name clash between (the
> openjdk) libjpeg.so and
Hi Erik:
Please review this small fix to the build when linking
libfontmanager.so on Solaris. Further explanation in the bug.
Bug: https://bugs.openjdk.java.net/browse/JDK-8042208
Patch inline:
Looks good to me.
Tim
diff -r 830cc367f41b make/lib/Awt2dLibraries.gmk
--- a/make/lib/Awt2dLib
Hello,
Please review this small fix to the build when linking libfontmanager.so
on Solaris. Further explanation in the bug.
Bug: https://bugs.openjdk.java.net/browse/JDK-8042208
Patch inline:
diff -r 830cc367f41b make/lib/Awt2dLibraries.gmk
--- a/make/lib/Awt2dLibraries.gmk
+++ b/make/lib/Aw
Hello Sergey,
the change looks fine to me.
Thanks,
Andrew
On 4/30/2014 3:12 PM, Sergey Bylokhov wrote:
Hello.
Please review the small fix for jdk 9.
Makefile and README were fixed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8042199
Webrev can be found at:
http://cr.openjdk.java.net/~serb
Hello.
Please review the small fix for jdk 9.
Makefile and README were fixed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8042199
Webrev can be found at: http://cr.openjdk.java.net/~serb/8042199/webrev.00
--
Best regards, Sergey.
Hi Phil,
thanks for the review. I'll update the bug and bug and push the change
to client as requested.
You're right that the problem doesn't currently manifest in a plain
OpenJDK build. But in our proprietary builds we have some additional
instrumentation and logging code which includes ctype_is
15 matches
Mail list logo
