Re: [OpenJDK 2D-Dev] RFR: 8038875: Remove use of ServiceLoader in finding class implementing sun.java2d.pipe. RenderingEngine

2014-05-07 Thread Phil Race
On 5/7/14 5:18 PM, Jim Graham wrote: If they specify something on the command line, and that doesn't exist, then we end up with Pisces even if Ductus is available. Is that intentional? Well, I decided it was OK as the only people likely to use this were working on OpenJDK Pisces improvement

Re: [OpenJDK 2D-Dev] RFR: 8038875: Remove use of ServiceLoader in finding class implementing sun.java2d.pipe. RenderingEngine

2014-05-07 Thread Jim Graham
If they specify something on the command line, and that doesn't exist, then we end up with Pisces even if Ductus is available. Is that intentional? Also, why the switch from "getProperty(, default)" to the basic getProperty() and manually applying the default? ...jim

Re: [OpenJDK 2D-Dev] RFR: 8038875: Remove use of ServiceLoader in finding class implementing sun.java2d.pipe. RenderingEngine

2014-05-07 Thread Mandy Chung
On 5/7/2014 2:57 PM, Phil Race wrote: I did away with the doPrivileged and it seems fine ... http://cr.openjdk.java.net/~prr/8038875.1/ I'm glad that the doPrivileged block is reduced just to System.getProperty. Looks good while I still think it's worth considering replacing Class.forName(p

Re: [OpenJDK 2D-Dev] RFR: 8038875: Remove use of ServiceLoader in finding class implementing sun.java2d.pipe. RenderingEngine

2014-05-07 Thread Phil Race
I did away with the doPrivileged and it seems fine ... http://cr.openjdk.java.net/~prr/8038875.1/ -phil. On 05/07/2014 01:26 PM, Phil Race wrote: On 5/7/14 12:40 PM, Mandy Chung wrote: You may consider to use the 3-arg version of Class.forName and not to initialize the class. This is call

Re: [OpenJDK 2D-Dev] RFR: 8038875: Remove use of ServiceLoader in finding class implementing sun.java2d.pipe. RenderingEngine

2014-05-07 Thread Phil Race
On 5/7/14 12:40 PM, Mandy Chung wrote: You may consider to use the 3-arg version of Class.forName and not to initialize the class. This is called within a doPrivileged block and it's generally a good convention to invoke the class initialization of the specified class (from the system prop

Re: [OpenJDK 2D-Dev] RFR: 8038875: Remove use of ServiceLoader in finding class implementing sun.java2d.pipe. RenderingEngine

2014-05-07 Thread Mandy Chung
On 5/7/2014 12:40 PM, Phil Race wrote: On 5/7/14 12:26 PM, Mandy Chung wrote: On 5/7/2014 11:26 AM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8038875 http://cr.openjdk.java.net/~prr/8038875/ Thanks for taking this on. I have some minor comments: line 129: if sun.java2d.re

Re: [OpenJDK 2D-Dev] RFR: 8038875: Remove use of ServiceLoader in finding class implementing sun.java2d.pipe. RenderingEngine

2014-05-07 Thread Mandy Chung
On 5/7/2014 12:26 PM, Mandy Chung wrote: On 5/7/2014 11:26 AM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8038875 http://cr.openjdk.java.net/~prr/8038875/ Thanks for taking this on. I have some minor comments: line 129: if sun.java2d.renderer is set, it finds a custom Rend

Re: [OpenJDK 2D-Dev] RFR: 8038875: Remove use of ServiceLoader in finding class implementing sun.java2d.pipe. RenderingEngine

2014-05-07 Thread Phil Race
On 5/7/14 12:26 PM, Mandy Chung wrote: On 5/7/2014 11:26 AM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8038875 http://cr.openjdk.java.net/~prr/8038875/ Thanks for taking this on. I have some minor comments: line 129: if sun.java2d.renderer is set, it finds a custom Render

Re: [OpenJDK 2D-Dev] RFR: 8038875: Remove use of ServiceLoader in finding class implementing sun.java2d.pipe. RenderingEngine

2014-05-07 Thread Mandy Chung
On 5/7/2014 11:26 AM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8038875 http://cr.openjdk.java.net/~prr/8038875/ Thanks for taking this on. I have some minor comments: line 129: if sun.java2d.renderer is set, it finds a custom RenderingEngine from the bootclasspath (as the

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface->sw blit is extremely slow

2014-05-07 Thread Sergey Bylokhov
Hello, Jim. I have started to implement the second solution, and a prototype looks good to me. But I got a problem with an appropriate test, do I understand correctly that there is no way to understand is transparent volatile image premultiply alpha or not? Because if I draw a transparent volat

[OpenJDK 2D-Dev] RFR: 8038875: Remove use of ServiceLoader in finding class implementing sun.java2d.pipe. RenderingEngine

2014-05-07 Thread Phil Race
https://bugs.openjdk.java.net/browse/JDK-8038875 http://cr.openjdk.java.net/~prr/8038875/ This is in support of modularisation (ie jigsaw). After the fix alternate implementations are loaded using Class.forName() as specified by the system property sun.java2d.renderer. Note that only the built