Re: [OpenJDK 2D-Dev] AWT Dev Request for review: 8026385: [macosx] (awt) setjmp/longjmp changes the process signal mask on OS X

2014-05-15 Thread David DeHaven
Ping! Does this look OK? I've also filed an issue against JavaFX: https://javafx-jira.kenai.com/browse/RT-37125 -DrD- I tried not modifying libpng but still ended up with lingering references to longjmp in pngread.o, despite libpng having png_ptr-longjmp_fn (bug in libpng?). pngread.c

Re: [OpenJDK 2D-Dev] AWT Dev Request for review: 8026385: [macosx] (awt) setjmp/longjmp changes the process signal mask on OS X

2014-05-15 Thread Phil Race
Approved. -phil. On 5/15/2014 9:31 AM, David DeHaven wrote: Ping! Does this look OK? I've also filed an issue against JavaFX: https://javafx-jira.kenai.com/browse/RT-37125 -DrD- I tried not modifying libpng but still ended up with lingering references to longjmp in pngread.o, despite

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

2014-05-15 Thread Sergey Bylokhov
Hello, Anton. The fix looks good. Thanks. On 16.04.2014 18:32, Andrew Brygin wrote: Hello Anton, the fix looks fine to me. Thanks, Andrew On 4/16/2014 6:30 PM, anton nashatyrev wrote: Hello Andrew, you are right, the fix may be less relaxing but still conforming: if the height ==

[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-15 Thread Joe Darcy
Hello, Please review these change to fix JDK-8042864 : Fix raw and unchecked warnings in javax.print http://cr.openjdk.java.net/~darcy/8042864.0/ Patch below. Thanks, -Joe --- old/src/share/classes/javax/print/AttributeException.java 2014-05-15 12:04:19.0 -0700 +++

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-15 Thread Henry Jen
On 05/15/2014 12:07 PM, Joe Darcy wrote: Hello, Please review these change to fix JDK-8042864 : Fix raw and unchecked warnings in javax.print http://cr.openjdk.java.net/~darcy/8042864.0/ Patch below. Looks good to me, just nit-picking. ---

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-15 Thread Joe Darcy
Hi Henry, On 05/15/2014 03:46 PM, Henry Jen wrote: On 05/15/2014 12:07 PM, Joe Darcy wrote: Hello, Please review these change to fix JDK-8042864 : Fix raw and unchecked warnings in javax.print http://cr.openjdk.java.net/~darcy/8042864.0/ Patch below. Looks good to me, just