Hello Phil,
the change looks fine to me.
Thanks,
Andrew
On 8/27/2014 2:26 AM, Phil Race wrote:
Andrew (and at least one other brave soul), please review :-
http://cr.openjdk.java.net/~prr/8056122/
-phil.
Hello Clemens,
the fix and the test look fine to me. The test probably can be
simplified a bit
with using getSnapshot() method of VolatileImage class, but it does
not matter
much here.
Thanks,
Andrew
On 8/26/2014 11:35 PM, Phil Race wrote:
Andrew or Jennifer : can you add your review 2c
Andrew (and at least one other brave soul), please review :-
http://cr.openjdk.java.net/~prr/8056122/
-phil.
Andrew or Jennifer : can you add your review 2c
The 8u backport is worth doing as we have had 2 independent reports
of this. That backport needs to be approved by the 8u gatekeeper.
I can take care of that once this is in 9.
-phil.
On 8/26/14 12:25 PM, Clemens Eisserer wrote:
It needs the GPL
> It needs the GPL license (copied from another test to get the right one)
> and there's one typo : wether -> whether
Header added, thanks for finding the typo:
http://cr.openjdk.java.net/~ceisserer/8054638/WhiteTextColorTest.java
> Otherwise looks fine.
In case no other issues pop up and a sec
Hi Clemens,
It needs the GPL license (copied from another test to get the right one)
and there's one typo : wether -> whether
Otherwise looks fine.
-phil.
On 8/26/2014 11:44 AM, Clemens Eisserer wrote:
Hi Phil,
Please find the regression test at:
http://cr.openjdk.java.net/~ceisserer/805463
Hi Phil,
Please find the regression test at:
http://cr.openjdk.java.net/~ceisserer/8054638/WhiteTextColorTest.java
Thanks, Clemens
Hi Phil,
> Fix looks good. Is there a way you can check in a regression test along-side
> the fix
> else you'll need to add a 'noreg-' label on the JBS bug.
Thanks for the review - I'll write a regression test today.
- Clemens
