Re: [OpenJDK 2D-Dev] freetypescaler fix for fonts that start with a control point

2014-09-09 Thread Phil Race
I've tested the fix (manually) and it looks good. -phil. On 09/09/2014 02:47 PM, Phil Race wrote: Martin, Although I have yet to test it, the fix looks reasonable to me. Probably this decompose outline function supporting the callbacks was overlooked when this code was written. A jtreg test is

Re: [OpenJDK 2D-Dev] freetypescaler fix for fonts that start with a control point

2014-09-09 Thread Phil Race
Martin, Although I have yet to test it, the fix looks reasonable to me. Probably this decompose outline function supporting the callbacks was overlooked when this code was written. A jtreg test is tricky as you need to have font data available that exercises the buggy case and then use the resu

[OpenJDK 2D-Dev] RFR: 8056213 : Clean up unix/native/common/sun/awt

2014-09-09 Thread Phil Race
After looking at the issues in the bug report below I think the only think that must be fixed is the unnecessary inclusion of initIDS.c in libawt_xawt.so https://bugs.openjdk.java.net/browse/JDK-8056213 http://cr.openjdk.java.net/~prr/8056213/ I've tested this out on Linux and am submitting a

Re: [OpenJDK 2D-Dev] RFR(XXS): 8057934: Upgrade to LittleCMS 2.6 breaks AIX build

2014-09-09 Thread Sergey Bylokhov
The fix looks fine to me too. On 09.09.2014 22:18, Phil Race wrote: Approved -phil. On 09/09/2014 11:11 AM, Volker Simonis wrote: Hi, I've updated my webrev to reflect the fix which has now been pushed to LittleCMS mainline. It renames SNONE to SUNDEFINED :- https://github.com/mm2/Little-CMS

Re: [OpenJDK 2D-Dev] RFR(XXS): 8057934: Upgrade to LittleCMS 2.6 breaks AIX build

2014-09-09 Thread Phil Race
Approved -phil. On 09/09/2014 11:11 AM, Volker Simonis wrote: Hi, I've updated my webrev to reflect the fix which has now been pushed to LittleCMS mainline. It renames SNONE to SUNDEFINED :- https://github.com/mm2/Little-CMS/commit/5bc4f52ff6b2090863d824827a871cd6274e36e4 http://cr.openjdk.ja

Re: [OpenJDK 2D-Dev] RFR(XXS): 8057934: Upgrade to LittleCMS 2.6 breaks AIX build

2014-09-09 Thread Volker Simonis
Hi, I've updated my webrev to reflect the fix which has now been pushed to LittleCMS mainline. It renames SNONE to SUNDEFINED :- https://github.com/mm2/Little-CMS/commit/5bc4f52ff6b2090863d824827a871cd6274e36e4 http://cr.openjdk.java.net/~simonis/webrevs/8057934.v1/ Pease review. Thank you and

Re: [OpenJDK 2D-Dev] [9] Review request for 8057940 JCK test api/java_awt/Image/renderable/ParameterBlock fails with StackOverflowError

2014-09-09 Thread Phil Race
Ditto. -phil. On 9/9/2014 9:29 AM, Sergey Bylokhov wrote: Hi, Alexander. The fix looks good. On 09.09.2014 18:38, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8057940 webrev: http://cr.openjdk.java.net/~alexsch/8057940/webrev

Re: [OpenJDK 2D-Dev] [9] Review request for 8057940 JCK test api/java_awt/Image/renderable/ParameterBlock fails with StackOverflowError

2014-09-09 Thread Sergey Bylokhov
Hi, Alexander. The fix looks good. On 09.09.2014 18:38, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8057940 webrev: http://cr.openjdk.java.net/~alexsch/8057940/webrev.00 The fix reverts JDK-8049893 change which introduces in

[OpenJDK 2D-Dev] [9] Review request for 8057940 JCK test api/java_awt/Image/renderable/ParameterBlock fails with StackOverflowError

2014-09-09 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8057940 webrev: http://cr.openjdk.java.net/~alexsch/8057940/webrev.00 The fix reverts JDK-8049893 change which introduces infinity loop in the ParameterBlock.add(int)/set(int) methods after replacing Integer

[OpenJDK 2D-Dev] RFR(XXS): 8057934: Upgrade to LittleCMS 2.6 breaks AIX build

2014-09-09 Thread Volker Simonis
Hi, could you please review the following tiny fix for an AIX build problem intruduced by "8056122: Upgrade JDK to LittleCMS 2.6": http://cr.openjdk.java.net/~simonis/webrevs/8057934/ https://bugs.openjdk.java.net/browse/JDK-8057934 The problem is that the new version of LittleCMS now includes "

Re: [OpenJDK 2D-Dev] [9] request for review: 8041465: BMPImageReader read error using ImageReadParam with set sourceRectangle

2014-09-09 Thread Andrew Brygin
Hello Sergey, my preference is to leave the seek(bitmapStart) in the read() method in order to reduce potential overhead because readHedaer() is called very often. Thanks, Andrew On 9/8/2014 7:31 PM, Sergey Bylokhov wrote: Hi, Andrew. I am not an expert in this area, but probably the bug

Re: [OpenJDK 2D-Dev] RFR: 8056209 : Remove unused files for libawt

2014-09-09 Thread Magnus Ihse Bursie
On 2014-09-05 18:05, Phil Race wrote: PS i filed https://bugs.openjdk.java.net/browse/JDK-8057711 to track D3DShaderGen.c Thanks! /Magnus