Re: [OpenJDK 2D-Dev] RFR: copy/paste duplicated tests in some condition statements

2015-02-04 Thread Sergey Bylokhov
Hi, Phil. The fix looks good. On 04.02.2015 14:07, Andrew Brygin wrote: Hi Phil, the fix looks fine. Thanks, Andrew On 2/3/2015 11:14 PM, Phil Race wrote: Fixing the mistakes Sergey just pointed out : http://cr.openjdk.java.net/~prr/8072433/ I marked these no-reg clean up as both are not e

Re: [OpenJDK 2D-Dev] RFR: copy/paste duplicated tests in some condition statements

2015-02-04 Thread Andrew Brygin
Hi Phil, the fix looks fine. Thanks, Andrew On 2/3/2015 11:14 PM, Phil Race wrote: Fixing the mistakes Sergey just pointed out : http://cr.openjdk.java.net/~prr/8072433/ I marked these no-reg clean up as both are not easily reachable by tests. One being in the case we de-register bad fonts,

Re: [OpenJDK 2D-Dev] RFR: 6243376: JPEGImageWriter corrupts color for non-JFIF images with differing sample factors

2015-02-04 Thread Andrew Brygin
Hello Phil, the fix looks fine to me. Thanks, Andrew On 2/3/2015 9:34 PM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-6243376 http://cr.openjdk.java.net/~prr/6243376/ One-line fix we should have done a long time ago. The test was more work .. -phil.

Re: [OpenJDK 2D-Dev] Review Request: 4952954 abort flag is not cleared for every write operation for JPEG ImageWriter

2015-02-04 Thread Andrew Brygin
Hello Sergey, the change looks fine to me. Thanks, Andrew On 1/29/2015 1:51 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. After the fix a jpeg plugin will clear abort flag and reset the native state when the write method will be called after abort. Bug: https://bugs.ope

Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

2015-02-04 Thread Roman Kennke
> > http://mail.openjdk.java.net/pipermail/awt-dev/2015-January/008819.html > > > > I got no reply, so I'm sending it here, maybe it's a better fit? ;-) > > font related discussions should go to 2d-dev. > The change looks OK. But test it as much as > you can. The previous re-factoring in JDK7 > ha