Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

2015-02-05 Thread Phil Race
It should still be functional. Some day we are likely to remove it but not yet. In the event that we can't find fontconfig for some reason, this should allow us to limp along moderately well as opposed to being in dire straits. -phil. On 2/5/15 8:52 AM, Sergey Bylokhov wrote: Hello, Roman, Phi

Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

2015-02-05 Thread Mario Torre
Indeed, for quite some time now I believe we don't *really* need this fallback. While we're refactoring this, it would be nice to see this gone too. I'm sure Phil has better knowledge here to know for sure though. Cheers, Mario 2015-02-05 17:52 GMT+01:00 Sergey Bylokhov : > Hello, Roman, Phil

Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

2015-02-05 Thread Sergey Bylokhov
Hello, Roman, Phil. The fix looks fine except an absent documentation in new class and InternalError + 80 chars per line. But I have a question: do we really need this failback? 527 /* Using the X11 font path to locate font files is now a fallback 528* useful only if fontconfig

[OpenJDK 2D-Dev] Review Request for bug (JDK-8039345) Strange behaviour of per-pixel translucency on linux

2015-02-05 Thread prasanta sadhukhan
Hi, Please review a fix for this issue: 8039345 Strange behaviour of per-pixel translucency on linux Bug description: https://bugs.openjdk.java.net/browse/JDK-8039345 webrev: http://cr.openjdk.java.net/~serb/prasanta/8039345/webrev.00/ Note: A wrong (PictStandardRGB24) picture format was used f