Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-02-20 Thread Phil Race
On 2/20/2015 1:48 PM, Alan Bateman wrote: Mandy pointed to me to this review thread, I'm not otherwise on 2d-dev. First, just to put more context on this. The API for charsets is java.nio.charsets. It has a service provider interface and the module jdk.charsets is intended to be a service pro

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-02-20 Thread Alan Bateman
Mandy pointed to me to this review thread, I'm not otherwise on 2d-dev. First, just to put more context on this. The API for charsets is java.nio.charsets. It has a service provider interface and the module jdk.charsets is intended to be a service provider module with the double byte / exten

Re: [OpenJDK 2D-Dev] Review Request: (JDK-8048782) OpenJDK: PiscesCache : xmax/ymax rounding up can cause RasterFormatException.

2015-02-20 Thread Jim Graham
Hi Prasanta, This fixes the symptom without fixing the underlying issue which is that there is poor sharing of information between the objects in the Pisces package. The cache adds 1 to bboxX1 and bboxY1 for its own internal purposes - and it seems extremely questionable that it should do so

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-20 Thread Phil Race
Hi, On 2/20/2015 10:06 AM, Laurent Bourgès wrote: Dear all, I am pleased to see this discussion so intense with many different point of views. I am still looking for a concrete plan on how to improve openjdk's rasterizer: - I started by improving Pisces code (better memory management) - t

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-20 Thread Laurent Bourgès
Dear all, I am pleased to see this discussion so intense with many different point of views. I am still looking for a concrete plan on how to improve openjdk's rasterizer: - I started by improving Pisces code (better memory management) - then I made more refactoring and it became an alternative r

Re: [OpenJDK 2D-Dev] Review Request: (JDK-8048782) OpenJDK: PiscesCache : xmax/ymax rounding up can cause RasterFormatException.

2015-02-20 Thread Phil Race
Hi, The fix seems fine but the test needs to be amended - it doesn't have the GPL header. - we do NOT use @author tags in openjdk. There was actually an intent to remove them from source files opportunistically. - the indendation is all wrong and does not follow our style guidelines http://ww

Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

2015-02-20 Thread Volker Simonis
Hi Roman, thanks for the clarification. Volker On Fri, Feb 20, 2015 at 3:01 PM, Roman Kennke wrote: > Hi Volker, > > The patch doesn't change anything for the default graphics that use > X11FontManager. The internal error is only thrown on backends that explicitly > use FcFontManage, and thus

Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

2015-02-20 Thread Roman Kennke
Hi Volker, The patch doesn't change anything for the default graphics that use X11FontManager. The internal error is only thrown on backends that explicitly use FcFontManage, and thus require fontconfig. Regards, Roman Am 20.02.2015 14:49 schrieb Volker Simonis : > > We usually don't have fontc

Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

2015-02-20 Thread Volker Simonis
We usually don't have fontconfig on AIX and it would be nice if AWT would still work even without fontconfig. There are also other ancient operating systems without fontconfig like for example HP UX which are not currently supported by OpenJDK but by commercial licensees of the OpenJDK source base.

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-20 Thread Mario Torre
2015-02-20 1:08 GMT+01:00 Phil Race : > If there was initially zero impact on any production code I can see that > being > more acceptable but I don't understand why its a problem to demonstrate > this by putting it in an OpenJDK Project sandbox and thereby be something > we can build so that JCK