Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-24 Thread Jim Graham
Those changes were exactly what I was referring to. I don't see why we shouldn't make trimmed arrays when copying the shape. I'm pretty sure that the copy constructors are going to be overwhelmingly used to make a protected copy of an existing shape/path2d which is likely meant mostly for rea

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-24 Thread Mario Torre
Hi Laurent, Linking to external servers means the nice Oracle folks that are reviewing your patches can't access them for legal reason. We should get you an account on cr.openjdk.java.net so you could upload that there. I'm not entirely sure what it takes for that, I believe author status is eno

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-24 Thread Laurent Bourgès
Phil, here is my first attempt to produce a webrev for the marlin renderer (derived from 0.5.5 Unsafe) against graphics-rasterizer/jdk9/ http://jmmc.fr/~bourgesl/share/graphics-rasterizer/webrev-1/ Of course, it is a big patch that you can c

Re: [OpenJDK 2D-Dev] Request for comment: merging the openjdk client groups ?

2015-02-24 Thread Magnus Ihse Bursie
On 2015-02-19 01:06, Phil Race wrote: There would still be some 'division' as I expect the individual mailing lists to persist. From my "outsider" perspective, I think the suggested move makes sense. However, I hope one outcome would be the addition of a common mailing list. I'm often just gu

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-24 Thread Laurent Bourgès
Hi again, > > Ok, I have to submit a webrev. > > There is two marlin variants: > - marlin 0.4.5 > - marlin 0.5.5 using Unsafe for array allocation and random access to > store edge data as struct [float + int] > > Note: marlin 0.5.5 is 10% faster in my benchmarks. > > What variant do you pref

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-24 Thread Phil Race
Hi, On 02/24/2015 06:51 AM, Laurent Bourgès wrote: Ok, I have to submit a webrev. There is two marlin variants: - marlin 0.4.5 - marlin 0.5.5 using Unsafe for array allocation and random access to store edge data as struct [float + int] Note: marlin 0.5.5 is 10% faster in my benchmarks. W

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-24 Thread Laurent Bourgès
Jim, > Ah, wait, those constructors do copy the arrays without having to iterate the segments and grow the arrays, but they don't trim them. I'm trying to remember if there was a specific reason that we decided not to trim the arrays in those constructors, but the only "advantage" I can think of

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-24 Thread Jim Graham
Ah, wait, those constructors do copy the arrays without having to iterate the segments and grow the arrays, but they don't trim them. I'm trying to remember if there was a specific reason that we decided not to trim the arrays in those constructors, but the only "advantage" I can think of is t

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-24 Thread Jim Graham
Hi Laurent, On 2/24/15 6:51 AM, Laurent Bourgès wrote: FastPath2D would be public API. Perhaps that should be a separate discussion FastPath2D is only a improvement of the Path2D class to trim arrays in the clone() method but there is another solution: provide a new Path2D constructor

Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

2015-02-24 Thread Roman Kennke
> > We usually don't have fontconfig on AIX and it would be nice if AWT > > would still work even without fontconfig. There are also other ancient > > operating systems without fontconfig like for example HP UX which are > > not currently supported by OpenJDK but by commercial licensees of the > >

Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

2015-02-24 Thread Sergey Bylokhov
We usually don't have fontconfig on AIX and it would be nice if AWT would still work even without fontconfig. There are also other ancient operating systems without fontconfig like for example HP UX which are not currently supported by OpenJDK but by commercial licensees of the OpenJDK source base

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-24 Thread Laurent Bourgès
Phil, I asked several times how to contribute back marlin to openjdk since may >> 2014... as pisces patches ? or as an alternative renderer ? >> >> > As I've asked for a long time, a webrev you create against openJDK is what > I'd like to see. > I can't assess what a delta it would be against pisc

Re: [OpenJDK 2D-Dev] [9] Review Request: 4958064 JPGWriter does not throw UnsupportedException when canWriteSequence retuns false

2015-02-24 Thread Andrew Brygin
Hello Sergey, the fix looks fine to me. Thanks, Andrew On 2/9/2015 4:30 PM, Sergey Bylokhov wrote: Hello. Please review a small fix for jdk 9. The API Doc for ImageWriter.PrepareWriteSequence() claims that this method will throw UnsupportedOperationException when canWriteSequence() returns

Re: [OpenJDK 2D-Dev] Review Request for bug (JDK-8039345) Strange behaviour of per-pixel translucency on linux

2015-02-24 Thread Alexander Zvegintsev
the fix looks good to me. Thanks, Alexander. On 02/24/2015 02:26 PM, prasanta sadhukhan wrote: Thanks Alexander. Here is the updated webrev http://cr.openjdk.java.net/~serb/prasanta/8039345/webrev.02 Regards Prasanta On 2/19/2015 8:55 PM, Alexander Zvegintsev wrote: Could you explain bit mo