Re: [OpenJDK 2D-Dev] Review Request: (JDK-8077584) Value of java.awt.font.OpenType.TAG_OPBD is incorrect

2015-04-29 Thread prasanta sadhukhan
Hi All, Any feedback? Can this be committed? Regards Prasanta On 4/15/2015 5:07 PM, prasanta sadhukhan wrote: Hi, I would like a review for a jdk9 fix whereby TAG_OPBD tag is updated to correct value. Bug: https://bugs.openjdk.java.net/browse/JDK-8077584 webrev: http://cr.openjdk.java.net/~

Re: [OpenJDK 2D-Dev] RFR: 8078331: Upgrade JDK to use LittleCMS 2.7

2015-04-29 Thread Sergey Bylokhov
Looks fine to me. On 30.04.15 0:47, Phil Race wrote: Please review the 8u backport of the same http://cr.openjdk.java.net/~prr/8078331.8u/ I will ease this by noting the following - I generated the webrev by applying the 9 patch to 8u. - The changes differ from the JDK 9 patch only in the re

Re: [OpenJDK 2D-Dev] What is the point of CloseTTFontFileFunc?

2015-04-29 Thread Phil Race
I'll commit this to 9 and then we'll see about backports. -phil. On 04/28/2015 12:44 AM, Andrew Dinn wrote: Hi Martin, I have just raised https://bugs.openjdk.java.net/browse/JDK-8078654 and submitted (to this list) a patch for review which removes the unnecessary close function. It just needs

Re: [OpenJDK 2D-Dev] RFR 8078654: CloseTTFontFileFunc callback should be removed

2015-04-29 Thread Phil Race
I think this fix should be fine. There should be no reason we need to do anything here as the file should already be closed by the Java side which has demonstrably gone away so should have already closed the file before then. -phil. On 04/27/2015 03:07 AM, Andrew Dinn wrote: Please review this

Re: [OpenJDK 2D-Dev] RFR: 8078331: Upgrade JDK to use LittleCMS 2.7

2015-04-29 Thread Phil Race
Please review the 8u backport of the same http://cr.openjdk.java.net/~prr/8078331.8u/ I will ease this by noting the following - I generated the webrev by applying the 9 patch to 8u. - The changes differ from the JDK 9 patch only in the respect that JDk 9 had this one change (by us) that was n

Re: [OpenJDK 2D-Dev] RFR 8079067 : New version string scheme - Java2D

2015-04-29 Thread Iris Clark
Hi, Phil. This looks good to me. iris -Original Message- From: Phil Race Sent: Wednesday, April 29, 2015 10:44 AM To: 2d-dev Subject: [OpenJDK 2D-Dev] RFR 8079067 : New version string scheme - Java2D https://bugs.openjdk.java.net/browse/JDK-8079067 http://cr.openjdk.java.net/~prr/80790

Re: [OpenJDK 2D-Dev] RFR 8079067 : New version string scheme - Java2D

2015-04-29 Thread Jennifer Godinez
Looks good. Jennifer On 04/29/2015 10:43 AM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8079067 http://cr.openjdk.java.net/~prr/8079067/ Just deleting unused code. -phil.

Re: [OpenJDK 2D-Dev] RFR 8079067 : New version string scheme - Java2D

2015-04-29 Thread Sergey Bylokhov
Looks fine. On 29.04.15 20:43, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8079067 http://cr.openjdk.java.net/~prr/8079067/ Just deleting unused code. -phil. -- Best regards, Sergey.

[OpenJDK 2D-Dev] RFR 8079067 : New version string scheme - Java2D

2015-04-29 Thread Phil Race
https://bugs.openjdk.java.net/browse/JDK-8079067 http://cr.openjdk.java.net/~prr/8079067/ Just deleting unused code. -phil.

Re: [OpenJDK 2D-Dev] RFR: DebugFonts.java fails with stackoverflow error

2015-04-29 Thread Jennifer Godinez
Looks good. - Jennifer On 04/17/2015 12:27 PM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8076979/ https://bugs.openjdk.java.net/browse/JDK-8076979 -phil.