Re: [OpenJDK 2D-Dev] JDK-8081295: Build failed with GCC 5.1.1

2015-05-27 Thread Yasumasa Suenaga
I've uploaded webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8081295/webrev.01/ Please review. Thanks, Yasumasa On 2015/05/28 12:19, Yasumasa Suenaga wrote: > Hi all, > > I tried to build jdk9/dev on Fedora22 with GCC 5.1.1, however, it was failed. > I found several problems: > > > S

[OpenJDK 2D-Dev] JDK-8081295: Build failed with GCC 5.1.1

2015-05-27 Thread Yasumasa Suenaga
Hi all, I tried to build jdk9/dev on Fedora22 with GCC 5.1.1, however, it was failed. I found several problems: System: Fedora release 22 (Twenty Two) x86_64 - gcc-5.1.1-1.fc22.x86_64 Problems: 1. Array bounds check in GCC - jdk/src/java.desktop/share/native/libjavajpeg/jcmaster

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8041900 [macosx] Java forces the use of discrete GPU

2015-05-27 Thread Torgeir Veimo
This is one of the bugs that prevent IDEA to switching to JDK7/8 for IntelliJ by default. The JDK is perceived by a lot of users as an ill-behaved application on OS X because it forces use of the discrete GPU, drastically reducing battery life. This patch didn't work for me either, on a 2014 15" r

Re: [OpenJDK 2D-Dev] [9] Review Request: 8080847 Copying of overlapping memory should be improved in java2d

2015-05-27 Thread Jim Graham
Where do you see evidence that it can crash? ...jim On 5/27/2015 3:54 AM, Andrew Haley wrote: On 05/27/2015 11:36 AM, Sergey Bylokhov wrote: On 26.05.15 21:27, Jim Graham wrote: Undefined doesn't mean "may crash" in this case, it means that the contents of memory may not match

Re: [OpenJDK 2D-Dev] [9] Review Request: 8080847 Copying of overlapping memory should be improved in java2d

2015-05-27 Thread Jim Graham
I see no evidence that it can crash. Again, undefined does not mean "can crash". Someone joked on that thread that they should probably make memcpy crash on overlapping memory moves in a future release, but I don't see any evidence that anyone took them seriously. The entire thread is more a

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8041900 [macosx] Java forces the use of discrete GPU

2015-05-27 Thread Phil Race
Hello Denis, Once lots of people start to use the integrated CPU I suppose there is a non-zero likelihood of crashes and other problems with that too. I would like to see this (a) selected based on battery or similar, not fixed, (b) made controllable by a flag or similar, and once that is don

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8041900 [macosx] Java forces the use of discrete GPU

2015-05-27 Thread Denis Fokin
Hi Phil, Thank you for the comments. Actually, the battery life is not the only issue that experience our customers. I am getting crash reports that are reproducible only with discrete cards on MBP. Some users report hangs with discrete cards. All this issues are eliminated by switching on the

Re: [OpenJDK 2D-Dev] RFR(XS): 8081332: AIX: fix charset dependenicies after 8035302:Eliminate dependency on jdk.charsets from 2D font code.

2015-05-27 Thread Phil Race
+1. -phil. On 05/27/2015 10:52 AM, Volker Simonis wrote: Hi, can you please review the following small build fix for AIX: http://cr.openjdk.java.net/~simonis/webrevs/2015/8081332/ https://bugs.openjdk.java.net/browse/JDK-8081332 The bug as well as the discussion at http://mail.openjdk.java.n

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8041900 [macosx] Java forces the use of discrete GPU

2015-05-27 Thread Phil Race
I suppose that NSOpenGLPFAAllowOfflineRenderers must prevent whatever 'tickling' of the discrete GPU we do from automatically making it the active GPU ? This seems to merit a source code comment as at face value it seems like an API that allows you to use that (other) discrete GPU alongside the

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-05-27 Thread Volker Simonis
Hi Phil, thanks for looking at this. On Wed, May 27, 2015 at 7:18 PM, Phil Race wrote: > Oh .. I see how 8035302 would be implicated on AIX. > It was the removal of the now redundant wildcard "ext" imports for the > Oracle > platforms in the X11 charsets that no longer mattered for those but sti

[OpenJDK 2D-Dev] RFR(XS): 8081332: AIX: fix charset dependenicies after 8035302:Eliminate dependency on jdk.charsets from 2D font code.

2015-05-27 Thread Volker Simonis
Hi, can you please review the following small build fix for AIX: http://cr.openjdk.java.net/~simonis/webrevs/2015/8081332/ https://bugs.openjdk.java.net/browse/JDK-8081332 The bug as well as the discussion at http://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005431.html contain all the gory

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-05-27 Thread Phil Race
Oh .. I see how 8035302 would be implicated on AIX. It was the removal of the now redundant wildcard "ext" imports for the Oracle platforms in the X11 charsets that no longer mattered for those but still did for AIX. Most probably what you propose as quick solution is best but I'll defer to Xu

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-05-27 Thread Phil Race
Hi Volker, Sorry for breaking AIX but I think it may be more related to these bugs https://bugs.openjdk.java.net/browse/JDK-8073152 https://bugs.openjdk.java.net/browse/JDK-8073893 8035302 then takes advantage of these but did not create/update the per-platform configuration. I think the varianc

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-05-27 Thread Volker Simonis
Hi everybody, sorry, but as usually, I'm a little late to the game:) This change, along with change "8073152: Update Standard/ExtendedCharsets to work with module system" causes build failures on AIX. It took me some time to dig trough the build system, but I think that I at least have a weak un

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

2015-05-27 Thread Phil Race
OK .. it's a step forward, so approved, although there is more to be done. I do ask that you however restore this comment until you actually remove the constraint : 405 * - and the destination is opaque -phil. On 05/21/2015 07:23 AM, Andrew Brygin wrote: Hello Phil, I have changed th

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

2015-05-27 Thread Torgeir Veimo
I am still unable to get subpixel antialiasing to work for netbeans with this patch. Are there circumstances (eg. certain surface configuration or double buffering), where subpixel antialising will be disabled? On 27 May 2015 at 15:21, Torgeir Veimo wrote: > This looks extremely promising; > http

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8041900 [macosx] Java forces the use of discrete GPU

2015-05-27 Thread Denis Fokin
Hi, Sergey, Basically, you should close all apps that can switch the vc including the utility for switching video cards. Make sure in About This Mac -> Displays that the integrated card is enabled. Start an application with the patched version of Java. Check About This Mac -> Displays. Integra

[OpenJDK 2D-Dev] Fwd: [9] Review Request: JDK-8041900 [macosx] Java forces the use of discrete GPU

2015-05-27 Thread Torgeir Veimo
Same here, 2014 15" macbook pro. Running netbeans with openjdk from hg yesterday with this patch applied. On 28/05/2015, Sergey Bylokhov wrote: > Hi, Denis. > Can you describe the steps on how to test it. On my mac it still change > the vc. > > On 27.05.15 17:16, Denis Fokin wrote: >> Please revi

Re: [OpenJDK 2D-Dev] [9] Review Request: JDK-8041900 [macosx] Java forces the use of discrete GPU

2015-05-27 Thread Sergey Bylokhov
Hi, Denis. Can you describe the steps on how to test it. On my mac it still change the vc. On 27.05.15 17:16, Denis Fokin wrote: Please review the fix for jdk9 The fix allows do not force discrete video card usage on MacBook Pro models with two video cards. I have tested the fix on several M

[OpenJDK 2D-Dev] [9] Review Request: JDK-8041900 [macosx] Java forces the use of discrete GPU

2015-05-27 Thread Denis Fokin
Please review the fix for jdk9 The fix allows do not force discrete video card usage on MacBook Pro models with two video cards. I have tested the fix on several MPBs. Bug: https://bugs.openjdk.java.net/browse/JDK-8041900 Webrev: http://cr.openjdk.java.net/~denis/8041900/webrev.00

Re: [OpenJDK 2D-Dev] [9] Review Request: 8061831 [OGL] "java.lang.InternalError: not implemented yet" during the blit of VI to VI in xor mode

2015-05-27 Thread Andrew Brygin
Hello Sergey, the fix looks fine to me. Thanks, Andrew On 5/22/2015 7:59 PM, Sergey Bylokhov wrote: On 21.05.15 22:59, Jim Graham wrote: I'm curious about bufferClip in the converter routine. Does that help? Since we clip when we blit back to the destination in the last line, we don't nec

Re: [OpenJDK 2D-Dev] [9] Review Request: 8080847 Copying of overlapping memory should be improved in java2d

2015-05-27 Thread Andrew Haley
On 05/27/2015 11:36 AM, Sergey Bylokhov wrote: > On 26.05.15 21:27, Jim Graham wrote: >> Undefined doesn't mean "may crash" in this case, it means that the >> contents of memory may not match what you would expect if the regions >> overlap because it is just a dump copy loop that does not do any

Re: [OpenJDK 2D-Dev] [9] Review Request: 8080847 Copying of overlapping memory should be improved in java2d

2015-05-27 Thread Sergey Bylokhov
On 26.05.15 21:27, Jim Graham wrote: Undefined doesn't mean "may crash" in this case, it means that the contents of memory may not match what you would expect if the regions overlap because it is just a dump copy loop that does not do any aliasing checks. Since it is undefined it can crash, but