Re: [OpenJDK 2D-Dev] Review Request for bug (JDK-8080287): The image of BufferedImage.TYPE_INT_ARGB and BufferedImage.TYPE_INT_ARGB_PRE is blank

2015-08-04 Thread Phil Race
+1. -phil. On 08/04/2015 01:53 PM, Jim Graham wrote: That is true. I usually don't inspect the class I'm testing to see if a test is needed since the implementation could change. Instead I determine what conditions I want to verify and test those conditions whether or not I "know" that the

Re: [OpenJDK 2D-Dev] Review Request for bug (JDK-8080287): The image of BufferedImage.TYPE_INT_ARGB and BufferedImage.TYPE_INT_ARGB_PRE is blank

2015-08-04 Thread Jim Graham
That is true. I usually don't inspect the class I'm testing to see if a test is needed since the implementation could change. Instead I determine what conditions I want to verify and test those conditions whether or not I "know" that the code would be doing the right thing there. It's OK to

Re: [OpenJDK 2D-Dev] Double free bug in freetypeScaler.c

2015-08-04 Thread Phil Race
Yes, this is the right place. The way to submit patches is a bit more fuzzy but I think it'll be fine for this one. I reproduced the crash using your test. I've filed https://bugs.openjdk.java.net/browse/JDK-8132985 to track this. -phil. On 08/04/2015 07:46 AM, Heikki Aitakangas wrote: Greeti

Re: [OpenJDK 2D-Dev] [9] request for review: 8068749: Restrict javax.imageio.spi.ServiceRegistry to ImageIO types

2015-08-04 Thread Phil Race
There is no need to deprecate them. They are not harmful. -phil. On 08/04/2015 03:25 AM, Sergey Bylokhov wrote: Probably we can mark these classes as deprecated, in favor to java.util.ServiceLoader? On 03.08.15 23:49, Phil Race wrote: CCC is approved. So I will give this a "+1" .. you just ne

[OpenJDK 2D-Dev] Double free bug in freetypeScaler.c

2015-08-04 Thread Heikki Aitakangas
Greetings, The freeNativeResources function in freetypeScaler.c frees a pointer obtained from FreeType internals: stream = scalerInfo->face->stream; FT_Done_Face(scalerInfo->face); ...snip... if (stream != NULL) { free(stream); } This is done in order to free a FT_S

Re: [OpenJDK 2D-Dev] [9] request for review: 8068749: Restrict javax.imageio.spi.ServiceRegistry to ImageIO types

2015-08-04 Thread Sergey Bylokhov
Probably we can mark these classes as deprecated, in favor to java.util.ServiceLoader? On 03.08.15 23:49, Phil Race wrote: CCC is approved. So I will give this a "+1" .. you just need one other reviewer (if you did not get that already) and you can push. -phil. On 07/27/2015 07:10 PM, Stuart