Re: [OpenJDK 2D-Dev] [9] RFR JDK-8072682: getBounds call on graphics.getDeviceConfiguration() returning cached information

2015-10-12 Thread prasanta sadhukhan
Thanks for the review. I have removed the unused fields. Here's the modified webrev: http://cr.openjdk.java.net/~psadhukhan/8072682/webrev.01/ Hi Sergey, can you commit this fix? Regards Prasanta On 10/10/2015 2:02 AM, Jim Graham wrote: +1 for the fix and removing the fields. ...jim

[OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

2015-10-12 Thread Jayathirth D V
Hello All, Made small change on how we need to represent floating point constant in Java(1000.0 -> 1000.0F). Please find updated Webrev link: Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.01/ Please review. Thanks, Jay From: Jayathirth D V Sent:

Re: [OpenJDK 2D-Dev] [9] Review request for 8130136: Swing window sometimes fails to repaint partially when it becomes exposed

2015-10-12 Thread Alexander Potochkin
Hello Alexey The fix looks reasonable. However the javadoc for RemoveDC method should be updated. Could you please describe the new logic there? When does the GetHWnd() method return zero? Do we need to check it in RemoveDC? I guess you didn't add the test for a good reason, could you please

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8072682: getBounds call on graphics.getDeviceConfiguration() returning cached information

2015-10-12 Thread Jim Graham
Looks good! ...jim On 10/11/15 10:59 PM, prasanta sadhukhan wrote: Thanks for the review. I have removed the unused fields. Here's the modified webrev: http://cr.openjdk.java.net/~psadhukhan/8072682/webrev.01/ Hi Sergey, can you commit this fix? Regards Prasanta On 10/10/2015