Re: [OpenJDK 2D-Dev] Review Request: Small tweak in the DrawImage.java

2015-11-13 Thread Jim Graham
Looks good! ...jim On 11/13/2015 12:12 PM, Sergey Bylokhov wrote: On 13.11.15 1:50, Jim Graham wrote: I can add a comment that this code is for performance, what do you think? I'd like to see that, was there an updated diff? In either case, I don't think we should di

Re: [OpenJDK 2D-Dev] Review Request: Small tweak in the DrawImage.java

2015-11-13 Thread Sergey Bylokhov
On 13.11.15 1:50, Jim Graham wrote: I can add a comment that this code is for performance, what do you think? I'd like to see that, was there an updated diff? In either case, I don't think we should disturb the comment and test at the top, we should just add additional checks down below where

Re: [OpenJDK 2D-Dev] [9] Review request for 8073320 Windows HiDPI Graphics support

2015-11-13 Thread Alexander Scherbatiy
Hello, I have filled additional issues which has been discussed on the review: JDK-8076545 Text size is twice bigger under Windows L&F on Win 8.1 with HiDPI display JDK-8142966 Wrong cursor position in text components on HiDPI display JDK-8142961 Position, size and distance sca

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8039412, , Stack overflow on Linux using DialogTypeSelection.NATIVE

2015-11-13 Thread prasanta sadhukhan
Hi Phil, On 11/13/2015 12:23 AM, Philip Race wrote: I am 99% sure this breaks the API on Windows on Mac. Did you test what it does there ? It works on Windows as PrinterJob.pageDialog(attributes) calls pageDialog(PageFormat page) in WPrinterJob.java which overrides pageDialog(PageFormat) of R