Hi Phil,
I have updated webrev to explicitly set glyph image width/height to be 0
in case of NaN transform. Could you please review it?
http://cr.openjdk.java.net/~psadhukhan/8023213/webrev.02/
Regards
Prasanta
On 11/17/2015 3:23 AM, Phil Race wrote:
Would it not be better to be explicit in th
Note that the test case in JDK-8069348 seems to work OK for a scaled
graphics (it actually fails only if I set the uiScale to 1 for some
reason), but Swing scrolling is completely broken. I dug down to the
call to D3D->StretchRect and it was returning D3DERR_INVALIDCALL and
simply not doing an
That seems better. But one more question to get a point clarified.
You are using getDesktopWindow() which is for the primary monitor.
I assume that the 'inversion' results in the value being used to be
independent
of the monitor in a multi-mon situation and so when we move to a 2nd monitor
that
Hi Alexandr,
One bug - we should be using LOGPIXELSY instead of X.
Otherwise, the changes look OK except for the one question/issue which I
don't know/remember the answer for:
How does this interact with per-monitor APIs? I believe LOGPIXELSX will
not change until the user logs off and back
Looks good. Approved.
Jennifer
On 11/13/2015 2:26 PM, Philip Race wrote:
I have managed to create a regression test that I think I can trust on
OS X
Updated webrev :- http://cr.openjdk.java.net/~prr/7162125.1
-phil.
On 11/12/15, 9:48 PM, Philip Race wrote:
Bug: https://bugs.openjdk.java.ne
I ran SwingSet2 and JDK-8069348 immediately jumped out as being broken
to the point where SwingSet2 was not usable. We should definitely make
that a high priority to fix ASAP. There were a couple of other very
minor rendering issues, but they didn't really affect usability like
that bug...
Would it not be better to be explicit in this so as not to leave it to
chance ?
-phil.
On 11/05/2015 11:49 PM, prasanta sadhukhan wrote:
Hi Phil,
On 11/5/2015 4:54 AM, Philip Race wrote:
This does not look right to me. Who knows what data is on the canvas ?
it is not clear that it is 'blank'
This one reads like it should be obvious but I find it less so ..
The unsatisfying part is that we do not seem to know what caused
the IOException in the customer case.
Andrew came up with a way to reproduce the symptoms but we really
don't know what caused the exception in the case of the submit
Note that LOGPIXELSY is global and static between reboots so it doesn't
really matter which monitor is used to get the value.
Also, the issue is that the measurements are in pixels, so if we convert
them into a resolution independent measurement then the rest of the
scaling in the AWT/2D will
Approved.
-phil.
On 11/12/2015 10:23 PM, prasanta sadhukhan wrote:
Thanks Phil. I was indeed relying on non-presence of equals method in
PageFormat.
I have modified the webrev to use equality. Can you please review ?
http://cr.openjdk.java.net/~psadhukhan/8067059/webrev.01/
Regards
Prasanta
This looks good to me.
-s
On 11/13/2015 2:26 PM, Philip Race wrote:
I have managed to create a regression test that I think I can trust on
OS X
Updated webrev :- http://cr.openjdk.java.net/~prr/7162125.1
-phil.
On 11/12/15, 9:48 PM, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/brow
This looks good to me.
-s
On 11/13/2015 2:26 PM, Philip Race wrote:
I have managed to create a regression test that I think I can trust on
OS X
Updated webrev :- http://cr.openjdk.java.net/~prr/7162125.1
-phil.
On 11/12/15, 9:48 PM, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/brow
On 11/13/2015 12:24 AM, prasanta sadhukhan wrote:
Hi Phil,
On 11/13/2015 12:23 AM, Philip Race wrote:
I am 99% sure this breaks the API on Windows on Mac.
Did you test what it does there ?
It works on Windows as PrinterJob.pageDialog(attributes) calls
pageDialog(PageFormat page) in WPrinterJo
Looks good. Approved.
Jennifer
- Original Message -
From: prasanta.sadhuk...@oracle.com
To: philip.r...@oracle.com
Cc: 2d-dev@openjdk.java.net, rajeev.cham...@oracle.com
Sent: Friday, November 13, 2015 3:36:15 AM GMT -08:00 US/Canada Pacific
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JD
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8076545/webrev.02
- round is used instead of ceil
- inverted scales are used
Thanks,
Alexandr.
On 10/30/2015 10:40 PM, Jim Graham wrote:
In this case round may be better. ceil() is more for cases wh
I have managed to create a regression test that I think I can trust on OS X
Updated webrev :- http://cr.openjdk.java.net/~prr/7162125.1
-phil.
On 11/12/15, 9:48 PM, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-7162125
Fix: http://cr.openjdk.java.net/~prr/7162125/
The proble
16 matches
Mail list logo
